Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: replace Float64Array global by the primordials #31203

Conversation

Sebastien-Ahkrin
Copy link
Contributor

@Sebastien-Ahkrin Sebastien-Ahkrin commented Jan 6, 2020

Hello,
For this PR I have added Float64Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: Float64Array 
      message: "Use `const { Float64Array } = primordials;` instead of the global."

And just add Float64Array.

const {
  // [...]
  Float64Array,
} = primordials;

I hope this new PR will help you :x

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jan 6, 2020
@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

@BridgeAR
Copy link
Member

This needs a rebase.

@targos
Copy link
Member

targos commented Sep 28, 2020

Superseded by #35397

@targos targos closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants