Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: replace Float32Array global by the primordials #31195

Closed
wants to merge 1 commit into from
Closed

lib: replace Float32Array global by the primordials #31195

wants to merge 1 commit into from

Conversation

Sebastien-Ahkrin
Copy link
Contributor

Hello,
For this PR I have added Float32Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".

rules:
  no-restricted-globals:
  - name: Float32Array
      message: "Use `const { Float32Array } = primordials;` instead of the global."

And just add Set.

const {
  // [...]
  Float32Array,
} = primordials;

I hope this new PR will help you :x

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. util Issues and PRs related to the built-in util module. labels Jan 5, 2020
@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28225/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28248/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28267/

@Trott
Copy link
Member

Trott commented Jan 7, 2020

Landed in 92cef79

Trott pushed a commit that referenced this pull request Jan 7, 2020
@Sebastien-Ahkrin @Trott
lib: replace Float32Array global by the primordials
92cef79 
PR-URL: #31195
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott Trott closed this Jan 7, 2020
MylesBorins pushed a commit that referenced this pull request Jan 16, 2020
@Sebastien-Ahkrin @MylesBorins
lib: replace Float32Array global by the primordials
f7833ac 
PR-URL: #31195
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Jan 16, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 14, 2020
@Sebastien-Ahkrin @codebytere
lib: replace Float32Array global by the primordials
41f0fa7 
PR-URL: #31195
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Sebastien-Ahkrin @nodejs-github-bot @Trott @jasnell @targos @cjihrig @gengjiawen @BridgeAR @trivikr