Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: support prepareSourceMap with source-maps #31143

Closed
wants to merge 4 commits into from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Dec 31, 2019

Adds support for Error.prepareStackTrace override, when --enable-source-maps is set.

See related #31132

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@bcoe bcoe changed the title error: support prepareSourceMap with source-maps errors: support prepareSourceMap with source-maps Dec 31, 2019
@nodejs-github-bot

This comment has been minimized.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 2, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@bcoe bcoe added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 2, 2020
@bcoe
Copy link
Contributor Author

bcoe commented Jan 2, 2020

looks like tests are green; I would love to fast track this if no one objects?

@BridgeAR
Copy link
Member

BridgeAR commented Jan 2, 2020

@bcoe no need to fast-track this, it may already land. It's open for more than two days and has at least two sign offs.

@BridgeAR BridgeAR added errors Issues and PRs related to JavaScript errors originated in Node.js core. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Jan 2, 2020
bcoe added a commit that referenced this pull request Jan 2, 2020
Adds support for Error.prepareStackTrace override, when
--enable-source-maps is set.

PR-URL: #31143
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@bcoe bcoe closed this Jan 2, 2020
@bcoe bcoe deleted the prepare-stack-trace branch January 2, 2020 23:09
@bcoe
Copy link
Contributor Author

bcoe commented Jan 2, 2020

Landed in 9cdda60

BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
Adds support for Error.prepareStackTrace override, when
--enable-source-maps is set.

PR-URL: #31143
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos pushed a commit that referenced this pull request Jan 14, 2020
Adds support for Error.prepareStackTrace override, when
--enable-source-maps is set.

PR-URL: #31143
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
Adds support for Error.prepareStackTrace override, when
--enable-source-maps is set.

PR-URL: #31143
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants