tools: allow the travis commit message job to fail #31116
Conversation
Travis often fails due to a commit message that does not adhere to the commit guidelines. We are able to fix the commit message while landing and it often confuses new contributors that travis fails. Keeping the check in place but allowing a test failure to report success should be a good middle ground.
nodejs-github-bot
added
the
build
BridgeAR
added
the
author ready
|
Isn't failing desired, it reports that the commit messages failed to adhere to the guidelines in CONTRIBUTING.md, and wouldn't contributors want to know that so they can fix it? Someone landing can rewrite the original commit messages, but I alwasy feel a bit uncomfortable about that when I do it. It can be considered helpful, but its also attributing my words to another person, possible spelling and grammatical errors and all, and means that the message that lands never gets reviewed by collaborators, because I invent it on the spot. I don't think tests that run but don't report a failure when they fail are very useful, since people don't tend to look at test results when the result is pass. We added the commit message test to notify people that there is a problem, might as well just remove the test if its not going to cause a red X in the github UI. And to be clear: this is not a blocking comment, just a question. |
|
I've approved but @sam-github has a valid point. |
|
The test as it is right now does not seem user friendly. I would still like to notify new contributors about faulty commit messages for the points mentioned above but doing it personally seems better than the travis job. Having a failing travis due to the commit message is confusing quite a few persons and I personally tend to ignore the travis result as "unreliable". I could check if it's possible to get different notifications back from travis. |
Travis often fails due to a commit message that does not adhere to the commit guidelines. We are able to fix the commit message while landing and it often confuses new contributors that travis fails. Keeping the check in place but allowing a test failure to report success should be a good middle ground. PR-URL: #31116 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Landed in 3abe3f2 🎉 |
Travis often fails due to a commit message that does not adhere to the commit guidelines. We are able to fix the commit message while landing and it often confuses new contributors that travis fails. Keeping the check in place but allowing a test failure to report success should be a good middle ground. PR-URL: #31116 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Travis often fails due to a commit message that does not adhere to the commit guidelines. We are able to fix the commit message while landing and it often confuses new contributors that travis fails. Keeping the check in place but allowing a test failure to report success should be a good middle ground. PR-URL: #31116 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Travis often fails due to a commit message that does not adhere to the commit guidelines. We are able to fix the commit message while landing and it often confuses new contributors that travis fails. Keeping the check in place but allowing a test failure to report success should be a good middle ground. PR-URL: #31116 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Travis often fails due to a commit message that does not adhere to
the commit guidelines. We are able to fix the commit message while
landing and it often confuses new contributors that travis fails.
Keeping the check in place but allowing a test failure to report
success should be a good middle ground.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes