build: warn upon --use-largepages config option #31103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
4 tasks
richardlau
approved these changes
Dec 27, 2019
|
Minor nit: the “Re:” in the commit message would usually be “Refs:”. |
gabrielschulhof
force-pushed
the
warn-about-largepages-compile-time
branch
from
586642b
to
38d4ed2
Compare
|
@richardlau I fixed the commit message. |
lundibundi
approved these changes
Dec 27, 2019
gabrielschulhof
force-pushed
the
warn-about-largepages-compile-time
branch
from
96c0b33
to
06d93fa
Compare
Emit a warning when the user configures with `--use-largepages` and/or `--use-largepages-script-lld` informing them that the option is now available as a Node.js runtime option once it is built. Refs: nodejs#31063 (comment)
gabrielschulhof
force-pushed
the
warn-about-largepages-compile-time
branch
from
06d93fa
to
3d7f054
Compare
lundibundi
added
the
author ready
|
CI: https://ci.nodejs.org/job/node-test-pull-request/27986/ -- stopped. |
gabrielschulhof
pushed a commit
that referenced
this pull request
Dec 28, 2019
Emit a warning when the user configures with `--use-largepages` and/or `--use-largepages-script-lld` informing them that the option is now available as a Node.js runtime option once it is built. Refs: #31063 (comment) PR-URL: #31103 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
|
Landed in c6822be. |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Dec 31, 2019
Emit a warning when the user configures with `--use-largepages` and/or `--use-largepages-script-lld` informing them that the option is now available as a Node.js runtime option once it is built. Refs: nodejs#31063 (comment) PR-URL: nodejs#31103 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
Emit a warning when the user configures with `--use-largepages` and/or `--use-largepages-script-lld` informing them that the option is now available as a Node.js runtime option once it is built. Refs: #31063 (comment) PR-URL: #31103 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2020
Emit a warning when the user configures with `--use-largepages` and/or `--use-largepages-script-lld` informing them that the option is now available as a Node.js runtime option once it is built. Refs: #31063 (comment) Backport-PR-URL: #31063 PR-URL: #31103 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Emit a warning when the user configures with `--use-largepages` and/or `--use-largepages-script-lld` informing them that the option is now available as a Node.js runtime option once it is built. Refs: #31063 (comment) Backport-PR-URL: #31063 PR-URL: #31103 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Merged
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Mar 6, 2020
Emit a warning when the user configures with `--use-largepages` and/or `--use-largepages-script-lld` informing them that the option is now available as a Node.js runtime option once it is built. Refs: nodejs#31063 (comment) PR-URL: nodejs#31103 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 9, 2020
Emit a warning when the user configures with `--use-largepages` and/or `--use-largepages-script-lld` informing them that the option is now available as a Node.js runtime option once it is built. Refs: nodejs#31063 (comment) PR-URL: nodejs#31103 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
targos
added
backported-to-v12.x
and removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Emit a warning when the user configures with `--use-largepages` and/or `--use-largepages-script-lld` informing them that the option is now available as a Node.js runtime option once it is built. Backport-PR-URL: nodejs#32092 Refs: nodejs#31063 (comment) PR-URL: nodejs#31103 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Emit a warning when the user configures with `--use-largepages` and/or `--use-largepages-script-lld` informing them that the option is now available as a Node.js runtime option once it is built. Backport-PR-URL: #32092 Refs: #31063 (comment) PR-URL: #31103 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit a warning when the user configures with
--use-largepagesand/or--use-largepages-script-lldinforming them that the option is nowavailable as a Node.js runtime option once it is built.
Re: #31063 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes