-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark: add benchmark on async_hooks enabled http server #31100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks test/benchmark/test-benchmark-async-hooks.js (which isn't run on every pull request but is run on nightly runs). You'll want to add the asyncHooks
and c
settings to that test. (Or add asyncHooks
only and rename c
to n
in this benchmark.)
Feel free to dismiss this "request changes" review once the test is updated and passing.
0795d79
to
e57bf76
Compare
e57bf76
to
500b240
Compare
Just updated the ordering according to @Trott 's suggestion. |
PR-URL: #31100 Refs: nodejs/diagnostics#124 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in bf7265f 🎉 |
PR-URL: #31100 Refs: nodejs/diagnostics#124 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #31100 Refs: nodejs/diagnostics#124 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #31100 Refs: nodejs/diagnostics#124 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>
Refs: nodejs/diagnostics#124
FWIW following is the result of the benchmark:
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes