doc: improve dns introduction #31090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dns
4 tasks
cjihrig
approved these changes
Dec 25, 2019
Trott
added
the
author ready
jasnell
approved these changes
Dec 26, 2019
lpinca
approved these changes
Dec 26, 2019
trivikr
approved these changes
Dec 27, 2019
The introductory paragraphs for the `dns` module do not explain what the module is for. Add a short (two brief sentences) explanation. It also emphasizes that functions in the dns module are divided into two categories, but that there is only one function in one of the categories, making the whole categories thing a bit odd to emphasize. Keep the material about the distinctions without discussing categories. There are other incidental revisions (changing an example IP to `example.org` and so on). PR-URL: nodejs#31090 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Landed in 40d363d |
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
The introductory paragraphs for the `dns` module do not explain what the module is for. Add a short (two brief sentences) explanation. It also emphasizes that functions in the dns module are divided into two categories, but that there is only one function in one of the categories, making the whole categories thing a bit odd to emphasize. Keep the material about the distinctions without discussing categories. There are other incidental revisions (changing an example IP to `example.org` and so on). PR-URL: #31090 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
The introductory paragraphs for the `dns` module do not explain what the module is for. Add a short (two brief sentences) explanation. It also emphasizes that functions in the dns module are divided into two categories, but that there is only one function in one of the categories, making the whole categories thing a bit odd to emphasize. Keep the material about the distinctions without discussing categories. There are other incidental revisions (changing an example IP to `example.org` and so on). PR-URL: #31090 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
The introductory paragraphs for the `dns` module do not explain what the module is for. Add a short (two brief sentences) explanation. It also emphasizes that functions in the dns module are divided into two categories, but that there is only one function in one of the categories, making the whole categories thing a bit odd to emphasize. Keep the material about the distinctions without discussing categories. There are other incidental revisions (changing an example IP to `example.org` and so on). PR-URL: #31090 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introductory paragraphs for the
dnsmodule do not explain what themodule is for. Add a short (two brief sentences) explanation.
It also emphasizes that functions in the dns module are
divided into two categories, but that there is only one function in one
of the categories, making the whole categories thing a bit odd to
emphasize. Keep the material about the distinctions without discussing
categories.
There are other incidental revisions (changing an example IP to
example.organd so on).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes