doc: improve doc net:server.listen #31064
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Remove line "Common parameter of server.listen() functions." from net:server.listen callback functions because there is no need of this line. Fixes: #31019
gireeshpunathil
approved these changes
Dec 23, 2019
cjihrig
approved these changes
Dec 23, 2019
jasnell
approved these changes
Dec 23, 2019
gireeshpunathil
added
the
author ready
BridgeAR
approved these changes
Dec 24, 2019
BridgeAR
pushed a commit
that referenced
this pull request
Dec 25, 2019
Remove line "Common parameter of server.listen() functions." from net:server.listen callback functions because there is no need of this line. PR-URL: #31064 Fixes: #31019 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 5661466 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
Remove line "Common parameter of server.listen() functions." from net:server.listen callback functions because there is no need of this line. PR-URL: #31064 Fixes: #31019 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Remove line "Common parameter of server.listen() functions." from net:server.listen callback functions because there is no need of this line. PR-URL: #31064 Fixes: #31019 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Remove line "Common parameter of server.listen() functions." from net:server.listen callback functions because there is no need of this line. PR-URL: #31064 Fixes: #31019 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove line "Common parameter of server.listen() functions."
from net:server.listen callback functions because there is no
need of this line.
Fixes: #31019
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes