Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: set arraybuffer_untransferable_private_symbol #31053

Closed
wants to merge 1 commit into from
Closed

src: set arraybuffer_untransferable_private_symbol #31053

wants to merge 1 commit into from

Conversation

thangktran
Copy link
Contributor

for ArrayBuffer whose buffers are not own by BackingStore. This
would help us avoid problem with the new V8 BackingStore API where new
ArrayBuffer is allocated at the same place of previous ArrayBuffer
that is still being tracked in BackingStore table.

Ref: #31052

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 21, 2019
addaleax
addaleax approved these changes Dec 21, 2019
View reviewed changes
src/node_buffer.cc Outdated Show resolved Hide resolved
@thangktran thangktran force-pushed the thangktran/issues/31052 branch 2 times, most recently from 744d23b to 354126c Compare December 21, 2019 16:12
cjihrig
cjihrig approved these changes Dec 22, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you revert the variable name change in src/node_buffer.cc. The diff isn't big, but the name change is distracting.

@thangktran
src: set arraybuffer_untransferable_private_symbol
0d11d4c 
for `ArrayBuffer` whose buffers are not own by `BackingStore`. This
would help us avoid problem with the new V8 BackingStore API where new
`ArrayBuffer` is allocated at the same place of previous `ArrayBuffer`
that is still being tracked in `BackingStore` table.

Ref: nodejs#31052
@thangktran
Copy link
Contributor Author

LGTM, but could you revert the variable name change in src/node_buffer.cc. The diff isn't big, but the name change is distracting.

fixed

@cjihrig
Copy link
Contributor

cjihrig commented Dec 23, 2019

Thank you! LGTM.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 23, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27885/

@thangktran thangktran mentioned this pull request Dec 23, 2019
Closed
BridgeAR pushed a commit that referenced this pull request Dec 25, 2019
@thangktran @BridgeAR
src: set arraybuffer_untransferable_private_symbol
90f7a5c 
for `ArrayBuffer` whose buffers are not own by `BackingStore`. This
would help us avoid problem with the new V8 BackingStore API where new
`ArrayBuffer` is allocated at the same place of previous `ArrayBuffer`
that is still being tracked in `BackingStore` table.

PR-URL: #31053
Refs: #31052
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR
Copy link
Member

Landed in 90f7a5c 🎉

@BridgeAR BridgeAR closed this Dec 25, 2019
@gireeshpunathil gireeshpunathil mentioned this pull request Dec 26, 2019
Closed
@BridgeAR
Copy link
Member

BridgeAR commented Jan 3, 2020

This does not land cleanly on v13.x. Please open a manual backport in case this should be backported or leave a comment to update the labels in case it should not be backported.

@thangktran
Copy link
Contributor Author

/cc @addaleax should this PR be backported to v13.x?

@addaleax
Copy link
Member

addaleax commented Jan 4, 2020

@thangktran I think it might be good to backport it, and the conflicts are likely going to be easy to resolve, but it’s definitely not critical.

@thangktran
Copy link
Contributor Author

@thangktran I think it might be good to backport it, and the conflicts are likely going to be easy to resolve, but it’s definitely not critical.

I'll prepare a PR for this.

@thangktran
Copy link
Contributor Author

thangktran commented Jan 4, 2020 •
edited
Loading

@addaleax i realized that this PR depends partially on some changes from #30782 which is not in v13.x-staging yet.

https://github.com/thangktran/node/blob/850a80b8a7b2fc8e1fcc3956c2860c3042576975/src/node_http2.h#L992

should i cherry-pick both to the backport PR?

@addaleax
Copy link
Member

addaleax commented Jan 4, 2020

@thangktran We marked that one as semver-major, so I don’t think we can do that really … I’ll just mark this PR here as dont-land-on-v13.x and we should be fine :)

@BethGriggs BethGriggs mentioned this pull request Apr 14, 2020
Merged
@targos targos added dont-land-on-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil left review comments

@richardlau richardlau richardlau left review comments

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@thangktran @cjihrig @nodejs-github-bot @BridgeAR @addaleax @Trott @richardlau @gireeshpunathil @targos