Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib: use for...of #31051

Closed
wants to merge 1 commit into from
Closed

zlib: use for...of #31051

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Dec 21, 2019

Searched for regular expression for \([^\.]*.length in lib and made changes in zlib submodule

Refs: #30910 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the zlib Issues and PRs related to the zlib subsystem. label Dec 21, 2019
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR mentioned this pull request Dec 24, 2019
2 tasks
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Dec 29, 2019

Needs a rebase...

@trivikr
Copy link
Member Author

trivikr commented Dec 29, 2019

Needs a rebase...

Done!

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Dec 31, 2019

Landed in 0a958f4

@Trott Trott closed this Dec 31, 2019
Trott pushed a commit that referenced this pull request Dec 31, 2019
PR-URL: #31051
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@trivikr trivikr deleted the zlib-for-of branch December 31, 2019 06:42
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
PR-URL: #31051
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #31051
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #31051
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #31051
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants