Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 6.8.0 #31044

Closed
wants to merge 1 commit into from
Closed

tools: update ESLint to 6.8.0 #31044

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 20, 2019

Update ESLint to 6.8.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
tools: update ESLint to 6.8.0
5e9cb7f 
Update ESLint to 6.8.0
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 20, 2019
BridgeAR
BridgeAR approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Trott
Trott approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

trivikr
trivikr approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27870/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 22, 2019 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/27874/ 💛

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 22, 2019
@Trott
Copy link
Member

Trott commented Dec 23, 2019

Landed in 5a0cd93

@Trott Trott closed this Dec 23, 2019
Trott pushed a commit that referenced this pull request Dec 23, 2019
@cjihrig @Trott
tools: update ESLint to 6.8.0
5a0cd93 
Update ESLint to 6.8.0

PR-URL: #31044
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@cjihrig cjihrig deleted the eslint branch December 23, 2019 01:26
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@cjihrig @BridgeAR
tools: update ESLint to 6.8.0
c779421 
Update ESLint to 6.8.0

PR-URL: #31044
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@cjihrig @targos
tools: update ESLint to 6.8.0
9d2e8c5 
Update ESLint to 6.8.0

PR-URL: #31044
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@cjihrig @BethGriggs
tools: update ESLint to 6.8.0
56fb29a 
Update ESLint to 6.8.0

PR-URL: #31044
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qard Qard Qard approved these changes

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @Trott @Qard @BridgeAR @trivikr @ZYSzys