Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: correct spelling and grammar #31026

Closed
wants to merge 3 commits into from
Closed

lib: correct spelling and grammar #31026

wants to merge 3 commits into from

Conversation

datatypevoid
Copy link
Contributor

@datatypevoid datatypevoid commented Dec 19, 2019 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the events Issues and PRs related to the events subsystem / EventEmitter. label Dec 19, 2019
addaleax
addaleax reviewed Dec 19, 2019
View reviewed changes
lib/events.js Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27825/

Trott pushed a commit that referenced this pull request Dec 22, 2019
@datatypevoid @Trott
lib: improve spelling and grammar in comment
312f308 
PR-URL: #31026
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 22, 2019

Landed in 312f308.

Thanks for the contribution! 🎉

@Trott Trott closed this Dec 22, 2019
@datatypevoid datatypevoid deleted the patch-1 branch December 23, 2019 22:18
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@datatypevoid @BridgeAR
lib: improve spelling and grammar in comment
a83d338 
PR-URL: #31026
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@datatypevoid @targos
lib: improve spelling and grammar in comment
4198d9a 
PR-URL: #31026
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@datatypevoid @BethGriggs
lib: improve spelling and grammar in comment
02fc95d 
PR-URL: #31026
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax left review comments

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@datatypevoid @nodejs-github-bot @Trott @addaleax @lpinca @gireeshpunathil @trivikr