lin: moved setting of this._decoder up in readline.Interface

[ww9rivers]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• Fixes: Exception thrown in readline.createInterface with input stream #30885

[Trott]

Welcome, @ww9rivers and thanks for the pull request. This change should have no effect due to the way the event loop works. Without a test that shows otherwise, I don't think this code should change.

related issue comments

[Trott]

I see in the related issue, you say this fixed the immediate problem. That is...surprising. (Regardless, we do need a test for this?)

[Trott]

@jasnell I'm confused. AFAICT, this would seem to basically be a no-op and shouldn't be expected to fix the cited issue. What am I missing?

[richardlau]

@ww9rivers Thank you for your contribution. Unfortunately I'm going to close this for the reasons mentioned by @Trott above, and also because this pull request is targetting v12.13.2-proposal when pull requests should target master (or, if not applicable to master, one of the *-staging branches).

[ww9rivers]

Sorry, I didn't watch my emails on this. I'll try again later.

One question: when I add a test for the issue, do I add it in the repo and include it in the pull-request?

Thanks! (My first time contributing to the project, your help would be much appreciated.)

[Trott]

One question: when I add a test for the issue, do I add it in the repo and include it in the pull-request?

Yes.