Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: replace Symbol.asyncIterator by SymbolAsyncIterator #30947

Closed
wants to merge 1 commit into from
Closed

lib: replace Symbol.asyncIterator by SymbolAsyncIterator #30947

wants to merge 1 commit into from

Conversation

Sebastien-Ahkrin
Copy link
Contributor

Just replaced every Symbol.asyncIterator by SymbolAsyncIterator in the lib/* folder
For this, i just have added SymbolAsyncIterator in the import

const {
  SymbolAsyncIterator,
} = primordials;

Of course i have removed unused import of Symbol 😄
I hope this pull request will help you ! :P

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. readline Issues and PRs related to the built-in readline module. stream Issues and PRs related to the stream subsystem. labels Dec 13, 2019
@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

addaleax
addaleax approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27642/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27662/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 14, 2019
@BridgeAR
Copy link
Member

@Sebastien-Ahkrin this has a conflict and needs a rebase.

@BridgeAR BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 15, 2019
@Sebastien-Ahkrin
Copy link
Contributor Author

Sebastien-Ahkrin commented Dec 15, 2019 •
edited
Loading

@BridgeAR I Apologize, i have updated my branch 😄

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27717/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27725/

@targos
Copy link
Member

targos commented Dec 16, 2019

Landed in 593240d

@targos targos closed this Dec 16, 2019
targos pushed a commit that referenced this pull request Dec 16, 2019
@Sebastien-Ahkrin @targos
lib: replace Symbol.asyncIterator by SymbolAsyncIterator
593240d 
PR-URL: #30947
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Sebastien-Ahkrin @MylesBorins
lib: replace Symbol.asyncIterator by SymbolAsyncIterator
92475e9 
PR-URL: #30947
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Sebastien-Ahkrin @targos
lib: replace Symbol.asyncIterator by SymbolAsyncIterator
5cfcf6f 
PR-URL: #30947
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Sebastien-Ahkrin @BethGriggs
lib: replace Symbol.asyncIterator by SymbolAsyncIterator
497a1c8 
PR-URL: #30947
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. readline Issues and PRs related to the built-in readline module. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Sebastien-Ahkrin @nodejs-github-bot @BridgeAR @targos @jasnell @Trott @addaleax @cjihrig @trivikr