lib: enforce use of Promise from primordials #30936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
Trott
approved these changes
Dec 13, 2019
devnexen
approved these changes
Dec 13, 2019
BridgeAR
approved these changes
Dec 13, 2019
cjihrig
approved these changes
Dec 13, 2019
trivikr
approved these changes
Dec 14, 2019
BridgeAR
added
the
author ready
jasnell
approved these changes
Dec 15, 2019
joyeecheung
approved these changes
Dec 15, 2019
| // Create copies of intrinsic objects that require a valid `this` to call | ||
| // static methods. | ||
| [ | ||
| 'Promise', |
There was a problem hiding this comment.
It might be more informative to reference https://www.ecma-international.org/ecma-262/#sec-promise.all here which has this note:
The all function requires its this value to be a constructor function that supports the parameter conventions of the Promise constructor.
(and so are other Promise "static" methods since Promise is a class, not just a namespace)
|
Landed in 7e5bf80 |
targos
added a commit
that referenced
this pull request
Dec 16, 2019
PR-URL: #30936 Refs: #30697 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30936 Refs: #30697 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
targos
added a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #30936 Refs: #30697 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30936 Refs: #30697 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #30697