util: add colors to debuglog() #30930
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
util
This adds colors to the passed through arguments in case the stream supports colors. The PID will also be highlighted.
BridgeAR
force-pushed
the
add-debuglog-colors
branch
from
c7b7c9a
to
5cfca89
Compare
This comment has been minimized.
This comment has been minimized.
|
@nodejs/util PTAL |
|
@nodejs/util this could use some reviews. |
|
The change LGTM. |
|
@targos I updated the initial post with a screenshot. |
|
@nodejs/util PTAL |
jasnell
approved these changes
Dec 24, 2019
BridgeAR
added
the
author ready
BridgeAR
added a commit
that referenced
this pull request
Dec 25, 2019
This adds colors to the passed through arguments in case the stream supports colors. The PID will also be highlighted. PR-URL: #30930 Reviewed-By: James M Snell <[email protected]>
|
Landed in a034583 🎉 |
BridgeAR
added a commit
that referenced
this pull request
Jan 3, 2020
This adds colors to the passed through arguments in case the stream supports colors. The PID will also be highlighted. PR-URL: #30930 Reviewed-By: James M Snell <[email protected]>
Merged
targos
added
baking-for-lts
codebytere
pushed a commit
that referenced
this pull request
Mar 14, 2020
This adds colors to the passed through arguments in case the stream supports colors. The PID will also be highlighted. PR-URL: #30930 Reviewed-By: James M Snell <[email protected]>
Merged
targos
removed
the
baking-for-lts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds colors to the passed through arguments in case the stream
supports colors. The PID will also be highlighted.
This is especially helpful in case we print errors: core stack frames are going to be greyed out in that case. It should also improve highlighting objects.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes