Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for validation for wasi.start() argument #30919

Merged
merged 0 commits into from
Dec 14, 2019
Merged

test: add test for validation for wasi.start() argument #30919

merged 0 commits into from
Dec 14, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 12, 2019

Improve test coverage in lib/wasi.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 12, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 12, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27596/

@gengjiawen gengjiawen added wasi Issues and PRs related to the WebAssembly System Interface. wasm Issues and PRs related to WebAssembly. labels Dec 13, 2019
@Trott Trott closed this Dec 14, 2019
@Trott Trott merged commit decc5f5 into nodejs:master Dec 14, 2019
@Trott
Copy link
Member Author

Trott commented Dec 14, 2019

Landed in decc5f5

@Trott Trott deleted the wasi-start-validation branch December 14, 2019 21:36
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Trott @MylesBorins
test: add test for validation for wasi.start() argument
60485dc 
PR-URL: #30919
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Trott @targos
test: add test for validation for wasi.start() argument
7139325 
PR-URL: #30919
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Trott @BethGriggs
test: add test for validation for wasi.start() argument
8f5ffff 
PR-URL: #30919
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. wasi Issues and PRs related to the WebAssembly System Interface. wasm Issues and PRs related to WebAssembly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @addaleax @lpinca @cjihrig @gengjiawen