Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: update Symbol.toStringTag by SymbolToStringTag primordial #30908

Closed
wants to merge 1 commit into from
Closed

lib: update Symbol.toStringTag by SymbolToStringTag primordial #30908

wants to merge 1 commit into from

Conversation

Sebastien-Ahkrin
Copy link
Contributor

This time i just replaced every Symboll.toStringTag by SymbolToStringTag in the lig/* folder.
I had to import SymbolToStringTag like that

const {
  SymbolToStringTag,
} = primordials;

I hope this pull request will help you ! :P

@nodejs-github-bot nodejs-github-bot added encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. util Issues and PRs related to the built-in util module. labels Dec 11, 2019
@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27611/

@Trott
Copy link
Member

Trott commented Dec 13, 2019

Landed in ac1cc5c

@Trott Trott closed this Dec 13, 2019
Trott pushed a commit that referenced this pull request Dec 13, 2019
@Sebastien-Ahkrin @Trott
lib: update Symbol.toStringTag by SymbolToStringTag primordial
ac1cc5c 
PR-URL: #30908
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Sebastien-Ahkrin @MylesBorins
lib: update Symbol.toStringTag by SymbolToStringTag primordial
0d2172f 
PR-URL: #30908
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Sebastien-Ahkrin @targos
lib: update Symbol.toStringTag by SymbolToStringTag primordial
d1702f5 
PR-URL: #30908
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Sebastien-Ahkrin @BethGriggs
lib: update Symbol.toStringTag by SymbolToStringTag primordial
0677649 
PR-URL: #30908
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Sebastien-Ahkrin @nodejs-github-bot @Trott @addaleax @targos @cjihrig @BridgeAR