Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: enforce use of BigInt from primordials #30882

Closed
wants to merge 1 commit into from
Closed

lib: enforce use of BigInt from primordials #30882

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Dec 10, 2019 •
edited
Loading

Refs: #30697

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. fs Issues and PRs related to the fs subsystem / file system. labels Dec 10, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27562/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 10, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27566/

@targos
Copy link
Member Author

targos commented Dec 13, 2019

Landed in 923d8bc

@targos targos closed this Dec 13, 2019
@targos targos deleted the primordials-bigint branch December 13, 2019 14:55
targos added a commit that referenced this pull request Dec 13, 2019
@targos
lib: enforce use of BigInt from primordials
923d8bc 
PR-URL: #30882
Refs: #30697
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2019
@targos @MylesBorins
lib: enforce use of BigInt from primordials
71c6d44 
PR-URL: #30882
Refs: #30697
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos added a commit that referenced this pull request Jan 14, 2020
@targos
lib: enforce use of BigInt from primordials
d4ea392 
PR-URL: #30882
Refs: #30697
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@targos @BethGriggs
lib: enforce use of BigInt from primordials
b92511d 
PR-URL: #30882
Refs: #30697
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@codebytere codebytere codebytere approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@targos @nodejs-github-bot @Trott @codebytere @cjihrig @BridgeAR @ZYSzys