Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark tests as flaky #30848

Closed
wants to merge 1 commit into from
Closed

test: mark tests as flaky #30848

wants to merge 1 commit into from

Conversation

joaocgreis
Copy link
Member

Mark a few tests that failed recently in master as flaky. Most of the tests are only marked flaky on Windows, except test-statwatcher that has failures documented for other platforms in its issue.

cc @nodejs/testing @nodejs/platform-windows

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Dec 8, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27471/

@joaocgreis
Copy link
Member Author

Please approve this comment for fast-tracking.

This is easy to change back if there's any objection, and would be good to have in master as soon as possible to help reading CI results for other PRs.

@joaocgreis joaocgreis added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 8, 2019
@joaocgreis joaocgreis mentioned this pull request Dec 8, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27473/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27476/

Trott pushed a commit that referenced this pull request Dec 8, 2019
@joaocgreis @Trott
test: mark tests as flaky
a2cfb7d 
PR-URL: #30848
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 8, 2019

Landed in a2cfb7d

@Trott Trott closed this Dec 8, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
@joaocgreis @targos
test: mark tests as flaky
305e45a 
PR-URL: #30848
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@joaocgreis @targos
test: mark tests as flaky
dc1bc15 
PR-URL: #30848
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@joaocgreis @BethGriggs
test: mark tests as flaky
2d39ed9 
PR-URL: #30848
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Feb 24, 2020
@joaocgreis @BethGriggs
test: mark tests as flaky
4b9a779 
PR-URL: #30848
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joaocgreis @nodejs-github-bot @Trott @addaleax @richardlau @gireeshpunathil