test: mark addons/openssl-bindings/test flaky on arm #30838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
addons
richardlau
added
arm
|
CI: https://ci.nodejs.org/job/node-test-pull-request/27457/ (From the above run here is the test failing and being marked flaky: https://ci.nodejs.org/job/node-test-binary-arm-12+/3034/RUN_SUBSET=addons,label=pi2-docker/) |
addaleax
approved these changes
Dec 7, 2019
cjihrig
approved these changes
Dec 7, 2019
|
Should we fast track this? I think so. 👍 here if you agree. |
ZYSzys
approved these changes
Dec 7, 2019
richardlau
added
the
fast-track
richardlau
added a commit
that referenced
this pull request
Dec 7, 2019
PR-URL: #30838 Refs: #30786 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
|
Landed in d4e00ec. |
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
PR-URL: #30838 Refs: #30786 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #30838 Refs: #30786 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30838 Refs: #30786 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #30786
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes