test: skip the unsupported test cases for IBM i #30819

dmabupt · 2019-12-06T07:22:22Z

This is a following PR of #30714.

The cases marked with // TODO need more investigations to identify if it is a system limit or can be resolved by code change. And I am working on it.

The other cases are identified that IBM i does not support them.

What we need to do is to indentify (and/or resolve) all the // TODO items.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

test/parallel/test-c-ares.js

test/parallel/test-child-process-spawnsync-validation-errors.js

test/parallel/test-child-process-uid-gid.js

test/async-hooks/test-fseventwrap.js

test/parallel/test-c-ares.js

test/parallel/test-child-process-fork-net-server.js

test/parallel/test-cli-node-options.js

test/parallel/test-fs-watch-close-when-destroyed.js

test/parallel/test-http-writable-true-after-close.js

bnoordhuis

High-level comment: you should decide on spelling it either as IBMi or IBM i but not both. :-)

test/async-hooks/test-fseventwrap.js

test/parallel/test-child-process-fork-net-server.js

test/parallel/test-http-writable-true-after-close.js

test/parallel/test-module-loading-error.js

test/parallel/test-os.js

test/sequential/test-inspector-contexts.js

sam-github · 2019-12-06T18:00:56Z

@dmabupt This is a Draft, so you should say what needs to be done to make it complete.

I assume that all the // TODO comments for example you intend to investigate and resolve them before requesting merge?

dmabupt · 2019-12-07T02:17:18Z

@dmabupt This is a Draft, so you should say what needs to be done to make it complete.

I assume that all the // TODO comments for example you intend to investigate and resolve them before requesting merge?

Yes, I am investigating the // TODO cases. And I just added the descriptions of what needs to be done.

richardlau · 2019-12-07T02:32:00Z

A suggestion regarding all of the common.skip()'s with TODO's -- If these are temporary with the intention to be investiagted and fixed later then another way might be to use the status files, e.g. (example with AIX)

node/test/sequential/sequential.status

Lines 21 to 23 in 4ec02d5

    
           [$system==aix] 
        
           # https://github.com/nodejs/node/pull/29054 
        
           test-buffer-creation-regression: SKIP

This would list all of them in one place (for each test bucket) and would mean the affected test files wouldn't need to be changed here. Would need IBMi detection to be added to

node/tools/utils.py

Lines 46 to 69 in 4ec02d5

    
           def GuessOS(): 
        
             id = platform.system() 
        
             if id == 'Linux': 
        
               return 'linux' 
        
             elif id == 'Darwin': 
        
               return 'macos' 
        
             elif id.find('CYGWIN') >= 0: 
        
               return 'cygwin' 
        
             elif id == 'Windows' or id == 'Microsoft': 
        
               # On Windows Vista platform.system() can return 'Microsoft' with some 
        
               # versions of Python, see http://bugs.python.org/issue1082 
        
               return 'win32' 
        
             elif id == 'FreeBSD': 
        
               return 'freebsd' 
        
             elif id == 'OpenBSD': 
        
               return 'openbsd' 
        
             elif id == 'SunOS': 
        
               return 'solaris' 
        
             elif id == 'NetBSD': 
        
               return 'netbsd' 
        
             elif id == 'AIX': 
        
               return 'aix' 
        
             else: 
        
               return None

dmabupt · 2019-12-07T13:58:41Z

A suggestion regarding all of the common.skip()'s with TODO's -- If these are temporary with the intention to be investiagted and fixed later then another way might be to use the status files, e.g. (example with AIX)

node/test/sequential/sequential.status

Lines 21 to 23 in 4ec02d5

[$system==aix]

# https://github.com/nodejs/node/pull/29054

test-buffer-creation-regression: SKIP

This would list all of them in one place (for each test bucket) and would mean the affected test files wouldn't need to be changed here. Would need IBMi detection to be added to

node/tools/utils.py

Lines 46 to 69 in 4ec02d5

def GuessOS():

id = platform.system()

if id == 'Linux':

return 'linux'

elif id == 'Darwin':

return 'macos'

elif id.find('CYGWIN') >= 0:

return 'cygwin'

elif id == 'Windows' or id == 'Microsoft':

# On Windows Vista platform.system() can return 'Microsoft' with some

# versions of Python, see http://bugs.python.org/issue1082

return 'win32'

elif id == 'FreeBSD':

return 'freebsd'

elif id == 'OpenBSD':

return 'openbsd'

elif id == 'SunOS':

return 'solaris'

elif id == 'NetBSD':

return 'netbsd'

elif id == 'AIX':

return 'aix'

else:

return None

GuessOS()

That is great.
The only concern is that GuessOS() returns either aix or os400. If let it return the real OS name, will it affect other modules reusing the aix code?

richardlau · 2019-12-07T14:11:02Z

GuessOS()

That is great.
The only concern is that GuessOS() returns either aix or os400. If let it return the real OS name, will it affect other modules reusing the aix code?

GuessOS() in tools/utils.py is only used to match things in the test *.status files. I think for IBMi it should return os400 (or ibmi, your choice). If there are existing tests that have entries in the status file for [$system==aix] that should also apply to IBMi we should just duplicate them for [$system==os400] (or [$system==ibmi]).

test/parallel/test-os.js

tools/utils.py

This is a following PR of #30714.

Original commit message: [base] Fix the return of ClockNow on IBMi The API thread_cputime() is only defined but not yet implemented on IBMi. Change-Id: I8ea7ff724e749f537b54e75a00d718500807ca8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1957831 Reviewed-by: Junliang Yan <[email protected]> Reviewed-by: Clemens Backes <[email protected]> Commit-Queue: Milad Farazmand <[email protected]> Cr-Commit-Position: refs/heads/master@{#65392} Refs: v8/v8@d406bfd

dmabupt · 2019-12-11T08:22:11Z

Seems this test case failed?

=== release test-process-env-allowed-flags-are-documented ===
Path: parallel/test-process-env-allowed-flags-are-documented
--- stderr ---
assert.js:99
  throw new AssertionError(obj);
  ^
AssertionError [ERR_ASSERTION]: The following options are documented as allowed in NODE_OPTIONS in /home/travis/build/nodejs/node/doc/api/cli.md: --insecure-http-parser but are not in process.allowedNodeEnvironmentFlags

richardlau · 2019-12-11T15:55:04Z

Seems this test case failed?

=== release test-process-env-allowed-flags-are-documented ===
Path: parallel/test-process-env-allowed-flags-are-documented
--- stderr ---
assert.js:99
  throw new AssertionError(obj);
  ^
AssertionError [ERR_ASSERTION]: The following options are documented as allowed in NODE_OPTIONS in /home/travis/build/nodejs/node/doc/api/cli.md: --insecure-http-parser but are not in process.allowedNodeEnvironmentFlags

I think that's a race condition between 02a0c74 landing on master and the last update to the commits in this PR. I've restarted the Travis CI.

nodejs-github-bot · 2019-12-24T17:15:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27915/

nodejs-github-bot · 2019-12-25T09:54:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27933/

This is a following PR of #30714. PR-URL: #30819 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Original commit message: [base] Fix the return of ClockNow on IBMi The API thread_cputime() is only defined but not yet implemented on IBMi. Change-Id: I8ea7ff724e749f537b54e75a00d718500807ca8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1957831 Reviewed-by: Junliang Yan <[email protected]> Reviewed-by: Clemens Backes <[email protected]> Commit-Queue: Milad Farazmand <[email protected]> Cr-Commit-Position: refs/heads/master@{#65392} Refs: v8/v8@d406bfd PR-URL: #30819 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

BridgeAR · 2019-12-25T22:20:47Z

Landed in 262c66a, bbc032d 🎉

This is a following PR of #30714. PR-URL: #30819 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Original commit message: [base] Fix the return of ClockNow on IBMi The API thread_cputime() is only defined but not yet implemented on IBMi. Change-Id: I8ea7ff724e749f537b54e75a00d718500807ca8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1957831 Reviewed-by: Junliang Yan <[email protected]> Reviewed-by: Clemens Backes <[email protected]> Commit-Queue: Milad Farazmand <[email protected]> Cr-Commit-Position: refs/heads/master@{#65392} Refs: v8/v8@d406bfd PR-URL: #30819 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

This is a following PR of #30714. PR-URL: #30819 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Original commit message: [base] Fix the return of ClockNow on IBMi The API thread_cputime() is only defined but not yet implemented on IBMi. Change-Id: I8ea7ff724e749f537b54e75a00d718500807ca8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1957831 Reviewed-by: Junliang Yan <[email protected]> Reviewed-by: Clemens Backes <[email protected]> Commit-Queue: Milad Farazmand <[email protected]> Cr-Commit-Position: refs/heads/master@{#65392} Refs: v8/v8@d406bfd PR-URL: #30819 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

This is a following PR of #30714. PR-URL: #30819 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Original commit message: [base] Fix the return of ClockNow on IBMi The API thread_cputime() is only defined but not yet implemented on IBMi. Change-Id: I8ea7ff724e749f537b54e75a00d718500807ca8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1957831 Reviewed-by: Junliang Yan <[email protected]> Reviewed-by: Clemens Backes <[email protected]> Commit-Queue: Milad Farazmand <[email protected]> Cr-Commit-Position: refs/heads/master@{#65392} Refs: v8/v8@d406bfd PR-URL: #30819 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Dec 6, 2019

addaleax approved these changes Dec 6, 2019

View reviewed changes

test/parallel/test-c-ares.js Outdated Show resolved Hide resolved

test/parallel/test-child-process-spawnsync-validation-errors.js Outdated Show resolved Hide resolved

test/parallel/test-child-process-uid-gid.js Outdated Show resolved Hide resolved

cjihrig reviewed Dec 6, 2019

View reviewed changes

bnoordhuis reviewed Dec 6, 2019

View reviewed changes

sam-github added the wip Issues and PRs that are still a work in progress. label Dec 6, 2019

BridgeAR reviewed Dec 8, 2019

View reviewed changes

test/parallel/test-os.js Show resolved Hide resolved

dmabupt commented Dec 8, 2019

View reviewed changes

tools/utils.py Outdated Show resolved Hide resolved

test: skip the unsupported test cases for IBM i

ae4905a

This is a following PR of #30714.

dmabupt marked this pull request as ready for review December 9, 2019 05:28

jasnell approved these changes Dec 15, 2019

View reviewed changes

BridgeAR approved these changes Dec 24, 2019

View reviewed changes

BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed wip Issues and PRs that are still a work in progress. labels Dec 24, 2019

BridgeAR closed this Dec 25, 2019

dmabupt deleted the ibmi_skipcase branch January 2, 2020 02:01

BridgeAR mentioned this pull request Jan 7, 2020

v13.6.0 proposal #31238

Merged

targos mentioned this pull request Jan 15, 2020

v12.15.0 release proposal #31368

Closed

MylesBorins mentioned this pull request Feb 8, 2020

v12.16.0 proposal #31691

Merged

MoLow mentioned this pull request Jun 18, 2023

test: skip test-runner-watch-mode on IBMi #48473

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: skip the unsupported test cases for IBM i #30819

test: skip the unsupported test cases for IBM i #30819

dmabupt commented Dec 6, 2019 •

edited

Loading

bnoordhuis left a comment

sam-github commented Dec 6, 2019

dmabupt commented Dec 7, 2019

richardlau commented Dec 7, 2019

dmabupt commented Dec 7, 2019

richardlau commented Dec 7, 2019

dmabupt commented Dec 11, 2019

richardlau commented Dec 11, 2019 •

edited

Loading

nodejs-github-bot commented Dec 24, 2019

nodejs-github-bot commented Dec 25, 2019

BridgeAR commented Dec 25, 2019

test: skip the unsupported test cases for IBM i #30819

test: skip the unsupported test cases for IBM i #30819

Conversation

dmabupt commented Dec 6, 2019 • edited Loading

Checklist

bnoordhuis left a comment

Choose a reason for hiding this comment

sam-github commented Dec 6, 2019

dmabupt commented Dec 7, 2019

richardlau commented Dec 7, 2019

dmabupt commented Dec 7, 2019

richardlau commented Dec 7, 2019

dmabupt commented Dec 11, 2019

richardlau commented Dec 11, 2019 • edited Loading

nodejs-github-bot commented Dec 24, 2019

nodejs-github-bot commented Dec 25, 2019

BridgeAR commented Dec 25, 2019

dmabupt commented Dec 6, 2019 •

edited

Loading

richardlau commented Dec 11, 2019 •

edited

Loading