Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: use CC instead of CXX when pointing to gcc #30817

Closed
wants to merge 2 commits into from
Closed

tools: use CC instead of CXX when pointing to gcc #30817

wants to merge 2 commits into from

Conversation

miladfarca
Copy link
Contributor

@miladfarca miladfarca commented Dec 6, 2019 •
edited
Loading

Currently gcc is pointing to CXX (g++) instead of the actual gcc which is causing failures when compiling V8

tools: use CC instead of CXX when pointing to gcc
2e61c63 
Current CC flag points to g++ instead of gcc which is causing failures when compiling V8
@nodejs-github-bot nodejs-github-bot added tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Dec 6, 2019
@miladfarca miladfarca mentioned this pull request Dec 6, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27388/

@gireeshpunathil
Copy link
Member

call for fast-track, helps resolving broken build. please 👍 if you are with me.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27393/

@gireeshpunathil
Copy link
Member

I see this in the CI: Jenkins is going to shut down - any idea? is part of a planned outage? @nodejs/build

@rvagg
Copy link
Member

rvagg commented Dec 6, 2019

unplanned, need to update and restart jenkins, waiting for current jobs to flush out and it'll be back up again and ready

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27398/

@targos
Copy link
Member

targos commented Dec 6, 2019

Only V8 CI uses this script: https://ci.nodejs.org/job/node-test-commit-v8-linux/2684/

@gireeshpunathil
Copy link
Member

Only V8 CI uses this script

@targos - does this mean the regular CI builds libv8* differently?

@targos
Copy link
Member

targos commented Dec 6, 2019

@gireeshpunathil regular CI builds V8 along with node (./configure, gyp, make)

mhdawson
mhdawson approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27404/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27430/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27431/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27438/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27441/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27442/

@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 7, 2019
richardlau pushed a commit that referenced this pull request Dec 7, 2019
@richardlau
tools: use CC instead of CXX when pointing to gcc
cf5ce2c 
Current CC flag points to g++ instead of gcc which is causing failures
when compiling V8.

PR-URL: #30817
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@richardlau
Copy link
Member

Fixed up the commit message and landed in cf5ce2c.

@richardlau richardlau closed this Dec 7, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
@targos
tools: use CC instead of CXX when pointing to gcc
1ed1a64 
Current CC flag points to g++ instead of gcc which is causing failures
when compiling V8.

PR-URL: #30817
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@targos
tools: use CC instead of CXX when pointing to gcc
7558d8b 
Current CC flag points to g++ instead of gcc which is causing failures
when compiling V8.

PR-URL: #30817
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@BethGriggs
tools: use CC instead of CXX when pointing to gcc
21ccbdd 
Current CC flag points to g++ instead of gcc which is causing failures
when compiling V8.

PR-URL: #30817
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Mar 2, 2020
@BethGriggs
tools: use CC instead of CXX when pointing to gcc
61e2d48 
Current CC flag points to g++ instead of gcc which is causing failures
when compiling V8.

PR-URL: #30817
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.