Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve WASI options validation #30800

Merged
merged 0 commits into from
Dec 7, 2019
Merged

test: improve WASI options validation #30800

merged 0 commits into from
Dec 7, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 5, 2019

Refs: https://github.com/nodejs/node/pull/30770/files#r353051438

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 5, 2019
@Trott Trott requested a review from BridgeAR December 5, 2019 04:16
@Trott Trott added the wasi Issues and PRs related to the WebAssembly System Interface. label Dec 5, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27340/

@Trott Trott closed this Dec 7, 2019
@Trott Trott merged commit 147317f into nodejs:master Dec 7, 2019
@Trott
Copy link
Member Author

Trott commented Dec 7, 2019

Landed in 147317f

targos pushed a commit that referenced this pull request Dec 9, 2019
@Trott @targos
test: improve WASI options validation
25e3696 
Refs: https://github.com/nodejs/node/pull/30770/files#r353051438

PR-URL: #30800
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Trott @targos
test: improve WASI options validation
bb8b11f 
Refs: https://github.com/nodejs/node/pull/30770/files#r353051438

PR-URL: #30800
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Trott @BethGriggs
test: improve WASI options validation
b5d59a7 
Refs: https://github.com/nodejs/node/pull/30770/files#r353051438

PR-URL: #30800
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
@Trott Trott deleted the wasi-validation branch April 14, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. wasi Issues and PRs related to the WebAssembly System Interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @jasnell @lpinca @cjihrig @BridgeAR @trivikr