Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/v8 Adding TypedArray to primordials #30740

Closed
wants to merge 2 commits into from
Closed

lib/v8 Adding TypedArray to primordials #30740

wants to merge 2 commits into from

Conversation

Sebastien-Ahkrin
Copy link
Contributor

Adding every TypedArray to the Primordials global objects.

And update v8 to ensure the usage of these TypedArray from primordials.

const {
  Array,
  ArrayBuffer,
  Float32Array,
  Float64Array,
  Int16Array,
  Int32Array,
  Int8Array,
  ObjectPrototypeToString,
  Uint16Array,
  Uint32Array,
  Uint8Array,
  Uint8ClampedArray,
} = primordials;

Thanks another time @targos
I hope this PR will help you :)

@Sebastien-Ahkrin
Copy link
Contributor Author

Hello,

I just have a test who fail this test

But i don't know why, someone have an idea ? 😢

thanks and sorry 😄

@tniessen tniessen added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 4, 2019
@targos targos mentioned this pull request Dec 4, 2019
Closed
@targos targos added the blocked PRs that are blocked by other issues or PRs. label Dec 4, 2019
@targos
Copy link
Member

targos commented Dec 4, 2019

This uncovered an existing bug.
Blocked by #30792

@targos
Copy link
Member

targos commented Dec 9, 2019

Refs: #30697

@targos targos mentioned this pull request Dec 10, 2019
Closed
@targos targos removed the blocked PRs that are blocked by other issues or PRs. label Dec 15, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27716/

@targos
Copy link
Member

targos commented Dec 16, 2019

Landed in 3743fe1...c88ace4

@targos targos closed this Dec 16, 2019
targos pushed a commit that referenced this pull request Dec 16, 2019
@Sebastien-Ahkrin @targos
lib: add TypedArray constructors to primordials
e9f2d7c 
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Dec 16, 2019
@Sebastien-Ahkrin @targos
v8: use of TypedArray constructors from primordials
c88ace4 
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Sebastien-Ahkrin @MylesBorins
lib: add TypedArray constructors to primordials
698e0a2 
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Sebastien-Ahkrin @MylesBorins
v8: use of TypedArray constructors from primordials
2b0e2c2 
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Sebastien-Ahkrin @targos
lib: add TypedArray constructors to primordials
b00fcaf 
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2020
@Sebastien-Ahkrin @targos
v8: use of TypedArray constructors from primordials
74f7844 
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Sebastien-Ahkrin @BethGriggs
lib: add TypedArray constructors to primordials
1092e0b 
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Sebastien-Ahkrin @BethGriggs
v8: use of TypedArray constructors from primordials
fbd9ea8 
PR-URL: #30740
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sebastien-Ahkrin @targos @nodejs-github-bot @jasnell @tniessen