Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: introduce ERR_TLS_INVALID_CONTEXT #30718

Closed
wants to merge 0 commits into from
Closed

tls: introduce ERR_TLS_INVALID_CONTEXT #30718

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 29, 2019

It is trivially possible to cause an internal assertion error with
tls.createSecurePair(). Throw a friendly error instead. Reserve internal
assertions for things that we believe to be impossible.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. tls Issues and PRs related to the tls subsystem. labels Nov 29, 2019
@Trott Trott added the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 29, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2019
@Trott
Copy link
Member Author

Trott commented Nov 29, 2019

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2098/

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2019
addaleax
addaleax requested changes Nov 29, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t have to be semver-major, imo

doc/api/errors.md Outdated Show resolved Hide resolved
@Trott Trott removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 30, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27194/

addaleax
addaleax approved these changes Nov 30, 2019
View reviewed changes
lib/internal/errors.js Outdated Show resolved Hide resolved
test/parallel/test-tls-basic-validations.js Outdated Show resolved Hide resolved
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 30, 2019 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/27197/ ✔️

Trott added a commit to Trott/io.js that referenced this pull request Dec 1, 2019
@Trott
tls: introduce ERR_TLS_INVALID_CONTEXT
d25db11 
It is trivially possible to cause an internal assertion error with
tls.createSecurePair(). Throw a friendly error instead. Reserve internal
assertions for things that we believe to be impossible.

PR-URL: nodejs#30718
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott Trott closed this Dec 1, 2019
@Trott
Copy link
Member Author

Trott commented Dec 1, 2019

Landed in d25db11

@Trott Trott deleted the not-internal branch December 1, 2019 20:08
targos pushed a commit that referenced this pull request Dec 2, 2019
@Trott @targos
tls: introduce ERR_TLS_INVALID_CONTEXT
7aa1df7 
It is trivially possible to cause an internal assertion error with
tls.createSecurePair(). Throw a friendly error instead. Reserve internal
assertions for things that we believe to be impossible.

PR-URL: #30718
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
@Trott @targos
tls: introduce ERR_TLS_INVALID_CONTEXT
7d5ab8b 
It is trivially possible to cause an internal assertion error with
tls.createSecurePair(). Throw a friendly error instead. Reserve internal
assertions for things that we believe to be impossible.

PR-URL: #30718
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Trott @BethGriggs
tls: introduce ERR_TLS_INVALID_CONTEXT
8a9243a 
It is trivially possible to cause an internal assertion error with
tls.createSecurePair(). Throw a friendly error instead. Reserve internal
assertions for things that we believe to be impossible.

PR-URL: #30718
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
This was referenced Sep 18, 2021
Open
Open
Open
@Dmarch28 Dmarch28 mentioned this pull request May 13, 2022
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 13, 2022
Open
@137717unity 137717unity mentioned this pull request May 13, 2022
Open
@baby636 baby636 mentioned this pull request May 13, 2022
Open
@kissofire kissofire mentioned this pull request May 13, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 13, 2022
Open
@ron-a20 ron-a20 mentioned this pull request May 13, 2022
Open
@molllyn1 molllyn1 mentioned this pull request May 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 25, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 28, 2023
Open
@baby636 baby636 mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github sam-github approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @sam-github @jasnell @addaleax @lpinca @cjihrig