-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc,n-api: mark napi_detach_arraybuffer as experimental #30703
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As its actual release stage.
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
node-api
Issues and PRs related to the Node-API.
labels
Nov 28, 2019
lundibundi
approved these changes
Nov 28, 2019
lpinca
approved these changes
Nov 28, 2019
mhdawson
approved these changes
Nov 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
addaleax
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Nov 28, 2019
tniessen
approved these changes
Nov 29, 2019
Landed in 120a477 |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
As its actual release stage. PR-URL: #30703 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
As its actual release stage. PR-URL: #30703 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 13, 2020
As its actual release stage. PR-URL: #30703 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
As its actual release stage. PR-URL: #30703 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
legendecas
added a commit
to legendecas/node
that referenced
this pull request
Jul 1, 2020
As its actual release stage. PR-URL: nodejs#30703 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
richardlau
pushed a commit
that referenced
this pull request
Jul 1, 2020
As its actual release stage. PR-URL: #30703 Backport-PR-URL: #33061 Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
node-api
Issues and PRs related to the Node-API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reflect its actual release stage.
Checklist