-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Number to Primordials #30700
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
Issues and PRs related to general changes in the lib or src directory.
label
Nov 28, 2019
Sebastien-Ahkrin
force-pushed
the
Number-enforce
branch
from
November 28, 2019 13:21
2935122
to
3ad8e2f
Compare
targos
reviewed
Nov 28, 2019
targos
approved these changes
Nov 28, 2019
cjihrig
approved these changes
Nov 28, 2019
trivikr
approved these changes
Nov 28, 2019
targos
force-pushed
the
Number-enforce
branch
from
November 30, 2019 12:52
48040d6
to
979ed18
Compare
targos
pushed a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30700 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Landed in 2070d3f. Thanks for the PR! |
This comment has been minimized.
This comment has been minimized.
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30700 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #30700 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30700 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update some file to replace Number to the primordial Number.
And i just have created a line in "/lib/.eslintrc.yaml".
And replace every code :
By
in theses files :
This task was given to me by @targos thanks ❤️
I hope this PR will help you :x