Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: enforce use of Boolean from primordials #30698

Closed
wants to merge 1 commit into from
Closed

lib: enforce use of Boolean from primordials #30698

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Nov 28, 2019

Refs: #30697

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Nov 28, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27158/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27206/

targos added a commit that referenced this pull request Nov 30, 2019
@targos
lib: enforce use of Boolean from primordials
7fc5980 
Refs: #30697

PR-URL: #30698
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@targos
Copy link
Member Author

targos commented Nov 30, 2019

Landed in 7fc5980.

@targos targos closed this Nov 30, 2019
@targos targos deleted the primordials-boolean branch November 30, 2019 12:39
targos added a commit that referenced this pull request Dec 1, 2019
@targos
lib: enforce use of Boolean from primordials
892bde6 
Refs: #30697

PR-URL: #30698
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
targos added a commit that referenced this pull request Jan 14, 2020
@targos
lib: enforce use of Boolean from primordials
2e81795 
Refs: #30697

PR-URL: #30698
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@targos @BethGriggs
lib: enforce use of Boolean from primordials
4151049 
Refs: #30697

PR-URL: #30698
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @nodejs-github-bot @benjamingr @cjihrig @trivikr @ZYSzys