doc: revise socket.connect() note #30691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit note in about `onread` option to `socket.connect()` for clarity.
nodejs-github-bot
added
doc
trivikr
approved these changes
Nov 27, 2019
Trott
added
the
author ready
addaleax
approved these changes
Nov 30, 2019
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
Edit note in about `onread` option to `socket.connect()` for clarity. PR-URL: #30691 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in 1b11039 |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
Edit note in about `onread` option to `socket.connect()` for clarity. PR-URL: #30691 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 5, 2019
Edit note in about `onread` option to `socket.connect()` for clarity. PR-URL: #30691 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Edit note in about `onread` option to `socket.connect()` for clarity. PR-URL: #30691 Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit note in about
onreadoption tosocket.connect()for clarity.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes