Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: promote _getCursorPos to public api #30687

Closed
wants to merge 5 commits into from
Closed

readline: promote _getCursorPos to public api #30687

wants to merge 5 commits into from

Commits on Dec 9, 2019

  1. readline: promote _getCursorPos to public api 

    Aliases Interface._getCursorPos to Interface.getCursorPos,
for consumption as a public API.

refs: nodejs#30347
    @Js-Brecht
    Js-Brecht committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    5f4f780 View commit details
    Browse the repository at this point in the history

  2. doc: readline.getCursorPos() documentation

    @Js-Brecht
    Js-Brecht committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    417dac1 View commit details
    Browse the repository at this point in the history

  3. readline: strip underscore from getCursorPos() 

    Alias _getCursorPos() = getCursorPos() for backwards
compatibility.
    @Js-Brecht
    Js-Brecht committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    98f47ac View commit details
    Browse the repository at this point in the history

  4. tests: change _getCursorPos() to getCursorPos()

    @Js-Brecht
    Js-Brecht committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    6b09369 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. YAML formatting 

    Co-Authored-By: Ruben Bridgewater <[email protected]>
    @Js-Brecht @BridgeAR
    Js-Brecht and BridgeAR authored Dec 10, 2019
    Configuration menu
    Copy the full SHA
    c784b7a View commit details
    Browse the repository at this point in the history