Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: fix session memory accounting after pausing #30684

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/node_http2.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1872,7 +1872,10 @@ void Http2Session::OnStreamRead(ssize_t nread, const uv_buf_t& buf_) {
nread = buf.size();
stream_buf_offset_ = 0;
stream_buf_ab_.Reset();
DecrementCurrentSessionMemory(stream_buf_offset_);

// We have now fully processed the stream_buf_ input chunk (by moving the
// remaining part into buf, which will be accounted for below).
DecrementCurrentSessionMemory(stream_buf_.len);
lundibundi marked this conversation as resolved.
Show resolved Hide resolved
}

// Shrink to the actual amount of used data.
Expand Down
55 changes: 55 additions & 0 deletions test/parallel/test-http2-large-writes-session-memory-leak.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const fixtures = require('../common/fixtures');
const http2 = require('http2');

// Regression test for https://github.com/nodejs/node/issues/29223.
// There was a "leak" in the accounting of session memory leading
// to streams eventually failing with NGHTTP2_ENHANCE_YOUR_CALM.

const server = http2.createSecureServer({
key: fixtures.readKey('agent2-key.pem'),
cert: fixtures.readKey('agent2-cert.pem'),
});

// Simple server that sends 200k and closes the stream.
const data200k = 'a'.repeat(200 * 1024);
server.on('stream', (stream) => {
stream.write(data200k);
stream.end();
});

server.listen(0, common.mustCall(() => {
const client = http2.connect(`https://localhost:${server.address().port}`, {
ca: fixtures.readKey('agent2-cert.pem'),
servername: 'agent2',

// Set maxSessionMemory to 1MB so the leak causes errors faster.
maxSessionMemory: 1
});

// Repeatedly create a new stream and read the incoming data. Even though we
// only have one stream active at a time, prior to the fix for #29223,
// session memory would steadily increase and we'd eventually hit the 1MB
// maxSessionMemory limit and get NGHTTP2_ENHANCE_YOUR_CALM errors trying to
// create new streams.
let streamsLeft = 50;
function newStream() {
const stream = client.request({ ':path': '/' });

stream.on('data', () => { });

stream.on('close', () => {
if (streamsLeft-- > 0) {
newStream();
} else {
client.destroy();
server.close();
}
});
}

newStream();
}));