Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 7.9.317.25 #30679

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 7.9.317.25 #30679

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Nov 27, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 27, 2019 •
edited by MylesBorins
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/27069/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2658/

@bricss
Copy link

bricss commented Nov 27, 2019

Does it also fixes that issue? #30586 🤔

@targos
Copy link
Member

targos commented Nov 27, 2019

@bricss no, but I opened #30681 to backport the fix

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27176/

addaleax pushed a commit that referenced this pull request Nov 30, 2019
@MylesBorins @addaleax
deps: patch V8 to 7.9.317.25
ea2668d 
Refs: v8/v8@7.9.317.23...7.9.317.25

PR-URL: #30679
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@addaleax
Copy link
Member

Landed in ea2668d

@addaleax addaleax closed this Nov 30, 2019
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@MylesBorins @addaleax
deps: patch V8 to 7.9.317.25
b470354 
Refs: v8/v8@7.9.317.23...7.9.317.25

PR-URL: #30679
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MylesBorins @nodejs-github-bot @bricss @targos @addaleax @cjihrig @gengjiawen