-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[readline doc] include line/cursor in readline documentation #30667
Conversation
Documents the existence and purpose of the `line` and `cursor` properties. `line` can be used for reading the current input value during runtime, if reading from a TTY stream. Both properties are necessary when developing a custom CLI input process using `readline` as a backend. Refs: nodejs#30347 Refs: DefinitelyTyped/DefinitelyTyped#40513
@nodejs/readline |
@addaleax Is it normal for it to take this long to get a review? Not trying to rush you guys at all; I'm sure that you all have tremendous work loads. Just wondering so I know what to expect 🙂 |
@Js-Brecht I mean, it depends, but pings are generally appreciated. I’m not sure I can really review this because it’s not obvious to me whether this should be public, documented API or not; in any case, |
@addaleax not sure who to ping here; I see you pinged the readline team already, so I suppose I can just wait for them.
That was my initial instinct, as well, until I saw this portion of the contributing guide:
I wasn't entirely sure if the practice was to use the version when the documentation was added, or when the property itself was added. Regardless, the standard syntax for the rest of the docs seem to include the YAML documentation, so I felt I would be remiss by not including it. If the version number here refers to when the documentation was added, then I'd imagine the I could just go with the lowest common denominator, but before I did that, I would need to go digging to see if I can find the first appearance 🤔. |
Yes, that would be the right thing here – it usually doesn’t matter because newly added documentation is also for newly added code :)
It’s v0.1.98 here. The reason for the class itself being marked with v0.1.104 is that that was when the class export was added; i.e. |
Co-Authored-By: Anna Henningsen <[email protected]>
Verified property exists at the creation of the readline module: version 0.1.98
Documents the existence and purpose of the `line` and `cursor` properties. `line` can be used for reading the current input value during runtime, if reading from a TTY stream. Both properties are necessary when developing a custom CLI input process using `readline` as a backend. Refs: #30347 Refs: DefinitelyTyped/DefinitelyTyped#40513 PR-URL: #30667 Reviewed-By: Anna Henningsen <[email protected]>
Landed in bd9be04 |
Documents the existence and purpose of the `line` and `cursor` properties. `line` can be used for reading the current input value during runtime, if reading from a TTY stream. Both properties are necessary when developing a custom CLI input process using `readline` as a backend. Refs: #30347 Refs: DefinitelyTyped/DefinitelyTyped#40513 PR-URL: #30667 Reviewed-By: Anna Henningsen <[email protected]>
Documents the existence and purpose of the `line` and `cursor` properties. `line` can be used for reading the current input value during runtime, if reading from a TTY stream. Both properties are necessary when developing a custom CLI input process using `readline` as a backend. Refs: #30347 Refs: DefinitelyTyped/DefinitelyTyped#40513 PR-URL: #30667 Reviewed-By: Anna Henningsen <[email protected]>
Documents the existence and purpose of the `line` and `cursor` properties. `line` can be used for reading the current input value during runtime, if reading from a TTY stream. Both properties are necessary when developing a custom CLI input process using `readline` as a backend. Refs: #30347 Refs: DefinitelyTyped/DefinitelyTyped#40513 PR-URL: #30667 Reviewed-By: Anna Henningsen <[email protected]>
Documents the existence and purpose of the
line
andcursor
properties, in an effort to make their usage public.line
can be used for reading the current input value during runtime, if reading from a TTY stream. Both properties are necessary when developing a custom CLI input process usingreadline
as an input processor. This allows you to utilize the work that's been done inreadline
, instead of trying to recreate it.Refs: #30347
Refs: DefinitelyTyped/DefinitelyTyped#40513
Checklist