Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix up N-API doc #30656

Closed
wants to merge 2 commits into from
Closed

doc: fix up N-API doc #30656

wants to merge 2 commits into from

Conversation

NickNaso
Copy link
Member

  • Fixed the signature for napi_status napi_get_uv_event_loop from:
NAPI_EXTERN napi_status napi_get_uv_event_loop(napi_env env,
                                               uv_loop_t** loop);

to:

NAPI_EXTERN napi_status napi_get_uv_event_loop(napi_env env,
                                               uv_loop_s** loop);
  • In section Simple Asynchronous Operations changed type napi_work to napi_async_work
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Nov 26, 2019
@NickNaso
Copy link
Member Author

@mhdawson @gabrielf If you have time please review this PR.

mhdawson
mhdawson approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

legendecas
legendecas reviewed Nov 28, 2019
View reviewed changes
doc/api/n-api.md Outdated Show resolved Hide resolved
@mhdawson
Copy link
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4091/

danbev pushed a commit that referenced this pull request Dec 4, 2019
@NickNaso @danbev
doc: fix up N-API doc
9ed67f4 
PR-URL: #30656
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@danbev
Copy link
Contributor

danbev commented Dec 4, 2019

Landed in 9ed67f4.

@danbev danbev closed this Dec 4, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
@NickNaso @targos
doc: fix up N-API doc
543bf9d 
PR-URL: #30656
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
@NickNaso @targos
doc: fix up N-API doc
1c452f0 
PR-URL: #30656
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@NickNaso @BethGriggs
doc: fix up N-API doc
005b601 
PR-URL: #30656
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NickNaso @mhdawson @danbev @legendecas @nodejs-github-bot