lib: enforce use of Array from primordials #30635
Conversation
nodejs-github-bot
added
the
lib / src
| ReflectConstruct(original, args, new.target) : | ||
| ReflectApply(original, this, args); | ||
| } | ||
| }[name], null); |
There was a problem hiding this comment.
This change is necessary, for two reasons:
- Some of the arrays we create are returned to the user
- Without it I'd also have to change calls to array methods
Also, It's probably better not to wrap the primordial functions for performance reasons, especially when we migrate String() and Number() calls in the future.
There was a problem hiding this comment.
hmm, wait, but why is Object.setPrototypeOf(..., null) removed here?
There was a problem hiding this comment.
Because if we stop wrapping the functions, it becomes useless, as there is nothing left to set the prototype of (we can't do that directly on the original functions).
There was a problem hiding this comment.
I see. To me making the Array namespace less mutable takes precedence over keeping these functions away from prototype poisoning, so LGTM.
targos
force-pushed
the
primordials-array
branch
from
b904161
to
5f67c62
Compare
| ReflectConstruct(original, args, new.target) : | ||
| ReflectApply(original, this, args); | ||
| } | ||
| }[name], null); |
There was a problem hiding this comment.
I see. To me making the Array namespace less mutable takes precedence over keeping these functions away from prototype poisoning, so LGTM.
targos
force-pushed
the
primordials-array
branch
from
5f67c62
to
cf1f94b
Compare
PR-URL: #30635 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
|
Landed in 141a6e3 |
PR-URL: #30635 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #30635 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #30635 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes