Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip test-domain-error-types in debug mode temporariliy #30629

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 24, 2019

Until #30498 is resolved, skip
test-domain-error-types on debug builds.

Not my first choice, but the frequency of failures in container+debug+shared-lib here is a problem.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 24, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

test/parallel/parallel.status Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 25, 2019
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member Author

Trott commented Nov 25, 2019

With the .status file approach, the test now doesn't show up at all in the results for the debug build. I would have thought it would be green-on-pass/yellow-on-fail. I'm puzzled by that. It is showing up in non-debug builds as expected.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 25, 2019

@richardlau
Copy link
Member

With the .status file approach, the test now doesn't show up at all in the results for the debug build. I would have thought it would be green-on-pass/yellow-on-fail. I'm puzzled by that. It is showing up in non-debug builds as expected.

#30629 (comment)

Until nodejs#30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: nodejs#30629
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott Trott merged commit 6d022c1 into nodejs:master Nov 26, 2019
@Trott
Copy link
Member Author

Trott commented Nov 26, 2019

Landed in 6d022c1

@Trott Trott deleted the skip-it branch November 26, 2019 18:20
addaleax pushed a commit that referenced this pull request Nov 30, 2019
Until #30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: #30629
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
BethGriggs pushed a commit that referenced this pull request Dec 23, 2019
Until #30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: #30629
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 27, 2019
BethGriggs pushed a commit that referenced this pull request Dec 31, 2019
Until #30498 is resolved, skip
test-domain-error-types on debug builds.

PR-URL: #30629
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants