Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: fix dynamic import from eval #30624

Closed
wants to merge 2 commits into from
Closed

module: fix dynamic import from eval #30624

wants to merge 2 commits into from

Conversation

coreyfarrell
Copy link
Member

This allows dynamic import to work from CLI --eval with or without
--input-type=module.

Fixes: #30591

Checklist

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Nov 24, 2019
@guybedford guybedford requested a review from devsnek November 25, 2019 00:43
yorkie
yorkie approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins added the esm Issues and PRs related to the ECMAScript Modules implementation. label Nov 27, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27066/

@coreyfarrell
Copy link
Member Author

I'm not sure what to do here, it doesn't look like the crash is caused by my change?

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
bcoe
bcoe suggested changes Nov 30, 2019
View reviewed changes
lib/internal/process/execution.js Outdated Show resolved Hide resolved
lib/internal/process/execution.js Outdated Show resolved Hide resolved
@guybedford guybedford requested a review from bcoe December 5, 2019 05:08
@bcoe
Copy link
Contributor

bcoe commented Dec 5, 2019

@coreyfarrell @guybedford this looks quite reasonable to me; @coreyfarrell when you have a moment, want to work on debugging the Travis tests? at which point I can kick off ci/cd?

@coreyfarrell
Copy link
Member Author

@bcoe the travis errors were unrelated and should be fixed by 781e41d, I've rebased to the current master.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@coreyfarrell

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
coreyfarrell and others added 2 commits December 5, 2019 19:39
@coreyfarrell
module: fix dynamic import from eval
da3f505 
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.

Fixes: nodejs#30591
@guybedford @coreyfarrell
tweak importModuleDynamically inlining
bcc0331
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27413/

bcoe
bcoe approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the most recent test run was successful, I am going to go ahead and land this.

bcoe pushed a commit that referenced this pull request Dec 7, 2019
@coreyfarrell @bcoe
module: fix dynamic import from eval
4ec02d5 
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.

Fixes: #30591

PR-URL: #30624
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yorkie Liu <[email protected]>
Reviewed-By: Ben Coe <[email protected]>
@bcoe
Copy link
Contributor

bcoe commented Dec 7, 2019

Landed in 4ec02d5

@bcoe bcoe closed this Dec 7, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
@coreyfarrell @targos
module: fix dynamic import from eval
d4aa656 
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.

Fixes: #30591

PR-URL: #30624
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yorkie Liu <[email protected]>
Reviewed-By: Ben Coe <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
@coreyfarrell @MylesBorins
module: fix dynamic import from eval
a91b735 
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.

Fixes: #30591

PR-URL: #30624
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yorkie Liu <[email protected]>
Reviewed-By: Ben Coe <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@coreyfarrell @BethGriggs
module: fix dynamic import from eval
cad5c2b 
This allows dynamic import to work from CLI `--eval` with or without
`--input-type=module`.

Fixes: #30591

PR-URL: #30624
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Yorkie Liu <[email protected]>
Reviewed-By: Ben Coe <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
@goto-bus-stop goto-bus-stop mentioned this pull request Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford left review comments

@devsnek devsnek devsnek approved these changes

@yorkie yorkie yorkie approved these changes

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic import not working on eval/print
7 participants
@coreyfarrell @nodejs-github-bot @bcoe @guybedford @yorkie @devsnek @MylesBorins