Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix signal handler crash on close #30582

Closed
wants to merge 1 commit into from
Closed

src: fix signal handler crash on close #30582

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

Closes #30581.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@codebytere codebytere requested a review from addaleax November 22, 2019 03:46
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. labels Nov 22, 2019
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 22, 2019
@addaleax
Copy link
Member

Feel free to 👍 this comment to approve fast-tracking

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26835/

@targos targos mentioned this pull request Nov 22, 2019
Closed
@ljharb ljharb mentioned this pull request Nov 22, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26840/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26846/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26848/

addaleax added a commit to addaleax/node that referenced this pull request Nov 22, 2019
@addaleax
test: add regression test for signal handler removal in exit
d51233c 
Refs: nodejs#30581
Refs: nodejs#30582
@addaleax addaleax mentioned this pull request Nov 22, 2019
Closed
3 tasks
@addaleax
Copy link
Member

Just for future reference, I dug a bit and opened a PR with a regression test in #30589 … this PR should obviously land first :) (And thanks @codebytere for taking care of this!)

mhdawson
mhdawson approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lundibundi
lundibundi approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@lundibundi lundibundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Also, latest CI (CI: https://ci.nodejs.org/job/node-test-pull-request/26848/) looks green, not sure why GitHub shows failures.

addaleax pushed a commit that referenced this pull request Nov 22, 2019
@codebytere @addaleax
src: fix signal handler crash on close
f171112 
PR-URL: #30582
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@addaleax
Copy link
Member

Landed in f171112 :)

@addaleax addaleax closed this Nov 22, 2019
@codebytere codebytere deleted the fix-handler-count-crash branch November 22, 2019 16:01
addaleax added a commit that referenced this pull request Nov 28, 2019
@addaleax
test: add regression test for signal handler removal in exit
ea7a6f9 
Refs: #30581
Refs: #30582

PR-URL: #30589
Refs: #30581
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@codebytere @addaleax
src: fix signal handler crash on close
1916acb 
PR-URL: #30582
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
addaleax added a commit that referenced this pull request Nov 30, 2019
@addaleax
test: add regression test for signal handler removal in exit
0972fa3 
Refs: #30581
Refs: #30582

PR-URL: #30589
Refs: #30581
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
@codebytere @targos
src: fix signal handler crash on close
bf43bf5 
PR-URL: #30582
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
targos pushed a commit that referenced this pull request Dec 1, 2019
@addaleax @targos
test: add regression test for signal handler removal in exit
cac77dd 
Refs: #30581
Refs: #30582

PR-URL: #30589
Refs: #30581
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@codebytere @MylesBorins
src: fix signal handler crash on close
8af3311 
PR-URL: #30582
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@addaleax @MylesBorins
test: add regression test for signal handler removal in exit
f5ac4ec 
Refs: #30581
Refs: #30582

PR-URL: #30589
Refs: #30581
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@lundibundi lundibundi lundibundi approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[13.2.0] Assertion `(new_handler_count) >= (0)' failed
8 participants
@codebytere @addaleax @nodejs-github-bot @cjihrig @gireeshpunathil @BethGriggs @lundibundi @mhdawson