Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix -Wsign-compare warnings #30565

Closed
wants to merge 1 commit into from
Closed

src: fix -Wsign-compare warnings #30565

wants to merge 1 commit into from

Commits on Nov 20, 2019

  1. src: fix -Wsign-compare warnings 

    This commit addresses the following compilation warnings:

../src/node_crypto.cc:5053:3: warning: comparison of integers
of different signs: 'unsigned int' and 'int' [-Wsign-compare]
  CHECK_EQ(n, BN_bn2binpad(r, data, n));

../src/node_crypto.cc:5054:3: warning: comparison of integers
of different signs: 'unsigned int' and 'int' [-Wsign-compare]
  CHECK_EQ(n, BN_bn2binpad(s, data + n, n));
    @cjihrig
    cjihrig committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    236de53 View commit details
    Browse the repository at this point in the history