deps: patch V8 to 7.9.317.23 #30560
Closed
deps: patch V8 to 7.9.317.23 #30560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
v8 engine
Merged
|
Can we please fast-track this |
MylesBorins
added
the
fast-track
addaleax
approved these changes
Nov 20, 2019
addaleax
added
the
author ready
cjihrig
approved these changes
Nov 20, 2019
|
failures on centos7 in V8 CI are these new? https://ci.nodejs.org/job/node-test-commit-v8-linux/2646/nodes=centos7-ppcle,v8test=v8test/ /cc @nodejs/build |
My understanding is that 2 failures are expected because of the Python 3 migration. |
This comment has been minimized.
This comment has been minimized.
gengjiawen
approved these changes
Nov 21, 2019
This comment has been minimized.
This comment has been minimized.
MylesBorins
added a commit
that referenced
this pull request
Nov 21, 2019
Refs: v8/v8@7.9.317.20...7.9.317.23 PR-URL: #30560 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
|
Landed in cf1f1de |
MylesBorins
added a commit
that referenced
this pull request
Nov 21, 2019
Refs: v8/v8@7.9.317.20...7.9.317.23 PR-URL: #30560 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@7.9.317.20...7.9.317.23