fs: fix existsSync for invalid symlink at win32 #30556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
pd4d10
changed the title
2 tasks
|
@nodejs/platform-windows @nodejs/fs |
|
The change looks reasonable. Rubberstamp LGTM if the test fails without this change. |
bnoordhuis
reviewed
Nov 22, 2019
lundibundi
reviewed
Nov 22, 2019
addaleax
approved these changes
Nov 30, 2019
addaleax
added
the
author ready
jasnell
approved these changes
Dec 1, 2019
|
Landed in 0e3d774 |
addaleax
pushed a commit
that referenced
this pull request
Dec 3, 2019
Fixes: #30538 PR-URL: #30556 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
Fixes: #30538 PR-URL: #30556 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 13, 2020
Fixes: #30538 PR-URL: #30556 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
hyj1991
added a commit
to X-Profiler/xprofiler
that referenced
this pull request
Jan 17, 2020
hyj1991
added a commit
to X-Profiler/xprofiler
that referenced
this pull request
Jan 18, 2020
Ref: nodejs/node#30556 PR-URL: https://github.com/hyj1991/xprofiler/pull/46 Reviewed-BY: hyj1991 <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Fixes: #30538 PR-URL: #30556 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30538
Background
#18618 uses
accessinstead ofstatto implementfs.existsSync. Unfortunately, seems the two approaches both have some limitations at Windows:existsSyncstataccessfalsetrueThis PR adds a double check only at win32 platform to fix this issue.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes