Refactored test-dgram-multicast-set-interface-lo.js by converting fun… #30536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions to arrow functions. Removed unused param('signal') from function to handle the death of a worker.
Trott
approved these changes
Nov 19, 2019
|
If I didn't mess it up, internet test suite CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/10181/ |
Trott
added
the
author ready
addaleax
approved these changes
Nov 19, 2019
Trott
approved these changes
Nov 22, 2019
Trott
pushed a commit
that referenced
this pull request
Nov 22, 2019
Convert functions to arrow functions. Remove unused param('signal') from
function.
PR-URL: #30536
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in a18ec07. Thanks for the contribution! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
Convert functions to arrow functions. Remove unused param('signal') from
function.
PR-URL: #30536
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
Convert functions to arrow functions. Remove unused param('signal') from
function.
PR-URL: #30536
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Merged
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Convert functions to arrow functions. Remove unused param('signal') from
function.
PR-URL: #30536
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ctions to arrow functions. Removed unused param('signal') from function to handle the death of a worker.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes