doc: fix overriding of prefix option #30518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the example in the "Building a debug build" section work as intended. Fixes: nodejs#30477
nodejs-github-bot
added
build
devnexen
approved these changes
Nov 17, 2019
trivikr
approved these changes
Nov 17, 2019
lundibundi
added
the
author ready
trivikr
pushed a commit
that referenced
this pull request
Nov 21, 2019
Make the example in the "Building a debug build" section work as intended. Fixes: #30477 PR-URL: #30518 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
Landed in f4b240f |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2019
Make the example in the "Building a debug build" section work as intended. Fixes: #30477 PR-URL: #30518 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
Make the example in the "Building a debug build" section work as intended. Fixes: #30477 PR-URL: #30518 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Make the example in the "Building a debug build" section work as intended. Fixes: #30477 PR-URL: #30518 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the example in the "Building a debug build" section work as
intended.
Fixes: #30477
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes