Skip to content

test: harden tmpdir/rmdirSync error handling #30517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lundibundi wants to merge 2 commits into from
Closed

test: harden tmpdir/rmdirSync error handling #30517

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbd30c5
test: harden tmpdir/rmdirSync error handling
lundibundi Nov 17, 2019
1c09a90
fixup! test: harden tmpdir/rmdirSync error handling
lundibundi Nov 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/common/tmpdir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function rmdirSync(p, originalEr) {
rimrafSync(path.join(p, f));
}
});
fs.rmdirSync(p);
rmdirSync(p, null);

@richardlau richardlau Nov 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does there need to be some sort of retry limit to avoid infinite loops?

@lundibundi lundibundi Nov 17, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it but it should only happen if someone is infinitely (or create-check-retry) creating files in a directory we are trying to remove.
Though, I can add a retry counter as a third argument just to be sure WDYT?

@richardlau richardlau Nov 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well there's got to be a reason that rimraf by default caps the number of retries, so I think some sort of limit would be good.

Long term it would be good if #30074 (which removes the custom rimraf implementation) could be fixed up.

@lundibundi lundibundi Nov 17, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

return;
}
throw e;
Expand Down