tools: fix build at non-English windows #30492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30492 +/- ##
==========================================
- Coverage 96.06% 93.26% -2.81%
==========================================
Files 185 404 +219
Lines 61301 98276 +36975
==========================================
+ Hits 58889 91656 +32767
- Misses 2412 6620 +4208
Continue to review full report at Codecov.
|
|
Found another issue probably related: #30461 |
addaleax
approved these changes
Nov 18, 2019
addaleax
added
the
author ready
danbev
approved these changes
Nov 19, 2019
danbev
pushed a commit
that referenced
this pull request
Nov 19, 2019
PR-URL: #30492 Fixes: #25885 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
|
Landed in 8fbbab8. |
BridgeAR
pushed a commit
that referenced
this pull request
Nov 19, 2019
PR-URL: #30492 Fixes: #25885 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
PR-URL: #30492 Fixes: #25885 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
PR-URL: #30492 Fixes: #25885 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #25885
There are some non-ASCII characters in v8's code, for example:
node/deps/v8/src/objects/intl-objects.cc
Line 1630 in 04e45db
This causes build failure at non-English windows. This PR adds
/utf-8compiler option to fix it.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes