src: expose ability to set options #30466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Nov 13, 2019
addaleax
added
embedding
cjihrig
approved these changes
Nov 13, 2019
6 tasks
devnexen
approved these changes
Nov 13, 2019
addaleax
added
the
author ready
codebytere
force-pushed
the
enable-passing-cli
branch
from
383049e
to
a3eb3b2
Compare
jasnell
approved these changes
Nov 14, 2019
2 tasks
codebytere
added a commit
that referenced
this pull request
Nov 18, 2019
PR-URL: #30466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 0f58bfd |
BridgeAR
pushed a commit
that referenced
this pull request
Nov 19, 2019
PR-URL: #30466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
added a commit
to BridgeAR/node
that referenced
this pull request
Nov 21, 2019
Notable changes:
* addons:
* Deprecate one- and two-argument `AtExit()`. Use the three-argument
variant of `AtExit()` or `AddEnvironmentCleanupHook()` instead
(Anna Henningsen) nodejs#30227
* child_process,cluster:
* The `serialization` option is added that allows child process
IPC to use the V8 serialization API (to e.g., pass through data
types like sets or maps) (Anna Henningsen)
nodejs#30162
* deps:
* Update V8 to 7.9
* Update `npm` to 6.13.0 (Ruy Adorno)
nodejs#30271
* embedder:
* Exposes the ability to pass cli flags / options through an API
as embedder (Shelley Vohr)
nodejs#30466
* Allow adding linked bindings to Environment (Anna Henningsen)
nodejs#30274
* esm:
* Unflag --experimental-modules (Guy Bedford)
nodejs#29866
* stream:
* Add `writable.writableCorked` property (Robert Nagy)
nodejs#29012
* worker:
* Allow specifying resource limits (Anna Henningsen)
nodejs#26628
* v8:
* The Serialization API is now stable (Anna Henningsen)
nodejs#30234
PR-URL: nodejs#30547
MylesBorins
added a commit
that referenced
this pull request
Nov 21, 2019
Notable changes:
* addons:
* Deprecate one- and two-argument `AtExit()`. Use the three-argument
variant of `AtExit()` or `AddEnvironmentCleanupHook()` instead
(Anna Henningsen) #30227
* child_process,cluster:
* The `serialization` option is added that allows child process
IPC to use the V8 serialization API (to e.g., pass through data
types like sets or maps) (Anna Henningsen)
#30162
* deps:
* Update V8 to 7.9
* Update `npm` to 6.13.0 (Ruy Adorno)
#30271
* embedder:
* Exposes the ability to pass cli flags / options through an API
as embedder (Shelley Vohr)
#30466
* Allow adding linked bindings to Environment (Anna Henningsen)
#30274
* esm:
* Unflag --experimental-modules (Guy Bedford)
#29866
* stream:
* Add `writable.writableCorked` property (Robert Nagy)
#29012
* worker:
* Allow specifying resource limits (Anna Henningsen)
#26628
* v8:
* The Serialization API is now stable (Anna Henningsen)
#30234
PR-URL: #30547
MylesBorins
pushed a commit
that referenced
this pull request
Jan 12, 2020
PR-URL: #30466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30466 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 12, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 12, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 12, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 15, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 15, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 18, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 18, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 21, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 21, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 21, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 21, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 24, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 24, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Feb 24, 2020
* chore: bump node in DEPS to v12.16.0 * Fixup asar support setup patch nodejs/node#30862 * Fixup InternalCallbackScope patch nodejs/node#30236 * Fixup GN buildfiles patch nodejs/node#30755 * Fixup low-level hooks patch nodejs/node#30466 * Fixup globals require patch nodejs/node#31643 * Fixup process stream patch nodejs/node#30862 * Fixup js2c modification patch nodejs/node#30755 * Fixup internal fs override patch nodejs/node#30610 * Fixup context-aware warn patch nodejs/node#30336 * Fixup Node.js with ltcg config nodejs/node#29388 * Fixup oaepLabel patch nodejs/node#30917 * Remove redundant ESM test patch nodejs/node#30997 * Remove redundant cli flag patch nodejs/node#30466 * Update filenames.json * Remove macro generation in GN build files nodejs/node#30755 * Fix some compilation errors upstream * Add uvwasi to deps nodejs/node#30258 * Fix BoringSSL incompatibilities * Fixup linked module patch nodejs/node#30274 * Add missing sources to GN uv build libuv/libuv#2347 * Patch some uvwasi incompatibilities * chore: bump Node.js to v12.6.1 * Remove mark_arraybuffer_as_untransferable.patch nodejs/node#30549 * Fix uvwasi build failure on win * Fixup --perf-prof cli option error * Fixup early cjs module loading * fix: initialize diagnostics properly nodejs/node#30025 * Disable new esm syntax specs nodejs/node#30219 * Fixup v8 weakref hook spec nodejs/node#29874 * Fix async context timer issue * Disable monkey-patch-main spec It relies on nodejs/node#29777, and we don't override prepareStackTrace. * Disable new tls specs nodejs/node#23188 We don't support much of TLS owing to schisms between BoringSSL and OpenSSL. Co-authored-by: Shelley Vohr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the ability to pass cli flags through an API for the embedder use case.
Electron needs to do its own parsing of arguments, and before this was unable to handle Node.js' cli flags at all, which prevented consumers from doing useful things like enabling experimental Node.js features.
cc @addaleax
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes