Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: handle undefined default_configuration #30465

Closed

Conversation

codebytere
Copy link
Member

This PR adds a check for process.config.target_defaults being undefined, as it is Electron's case, and ensures that the buildType is set to a default value of Release should it not be defined.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 13, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2019
@nodejs-github-bot
Copy link
Collaborator

test/common/index.js Outdated Show resolved Hide resolved
@codebytere
Copy link
Member Author

codebytere commented Nov 15, 2019

@trivikr your suggestion failed lint:

/home/travis/build/nodejs/node/test/common/index.js
  122:4  error  '?' should be placed at the end of the line  operator-linebreak
  123:4  error  ':' should be placed at the end of the line  operator-linebreak

are we fine for me to move back to the previous format?

I could also do this:

const buildType = process.config.target_defaults ?
  process.config.target_defaults.default_configuration :
  'Release';

i'm fairly un-opinionated on this front ¯\_(ツ)_/¯

@trivikr
Copy link
Member

trivikr commented Nov 15, 2019

Sure, this format works

const buildType = process.config.target_defaults ?
  process.config.target_defaults.default_configuration :
  'Release';

I'd posted my review as a nit, suggesting it's optional.

@codebytere codebytere force-pushed the handle-unset-defaultconfiguration branch from 7b72997 to 74cf1cd Compare November 16, 2019 16:32
@nodejs-github-bot
Copy link
Collaborator

@codebytere
Copy link
Member Author

Landed in 70281ce

codebytere added a commit that referenced this pull request Nov 18, 2019
PR-URL: #30465
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@codebytere codebytere closed this Nov 18, 2019
@codebytere codebytere deleted the handle-unset-defaultconfiguration branch November 18, 2019 17:24
BridgeAR pushed a commit that referenced this pull request Nov 19, 2019
PR-URL: #30465
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
targos pushed a commit that referenced this pull request Dec 1, 2019
PR-URL: #30465
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
PR-URL: #30465
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
codebytere added a commit to electron/electron that referenced this pull request Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants