net: improve performance by destructuring primordials #30447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gireeshpunathil
added
the
code-and-learn
|
I'm actually getting a linter error on a line I didn't change (L538): defineProperty(Socket.prototype, 'bufferSize', {
get: function() { // eslint-disable-line getter-return
if (this._handle) {
return this[kLastWriteQueueSize] + this.writableLength;
}
}
});Should I address that as part of this PR as well? |
lundibundi
reviewed
Nov 14, 2019
|
Also, it looks like we usually go with capitalized |
Ooops, renamed. Thanks for bearing with me! |
addaleax
approved these changes
Nov 18, 2019
gireeshpunathil
approved these changes
Nov 18, 2019
cjihrig
approved these changes
Nov 18, 2019
trivikr
approved these changes
Nov 18, 2019
lundibundi
approved these changes
Nov 18, 2019
gireeshpunathil
pushed a commit
that referenced
this pull request
Nov 19, 2019
Refs: #29766 PR-URL: #30447 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
landed in 5e4d99a, thanks for the contribution! |
BridgeAR
pushed a commit
that referenced
this pull request
Nov 19, 2019
Refs: #29766 PR-URL: #30447 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 1, 2019
Refs: #29766 PR-URL: #30447 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Refs: #29766 PR-URL: #30447 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #29766
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes