test: change test limit for atime from 2ms to 5ms #30437

duncanhealy · 2019-11-12T16:15:45Z

doc: change test limit for atime from 2ms to 5ms
fixes #24593

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

test/parallel/test-fs-stat-bigint.js

test/parallel/test-vm-function-declaration.js

Trott · 2019-11-12T18:39:25Z

I'm concerned that this change masks an actual bug. What's the reason to believe it doesn't?

addaleax · 2019-11-12T18:50:17Z

@Trott I think there are two changes which got mixed together here…

As for increasing the timeout, I’m okay because the test is just inherently flaky the way it’s written and we can’t really do anything about that.

Trott · 2019-11-12T18:52:06Z

As for increasing the timeout, I’m okay because the test is just inherently flaky the way it’s written and we can’t really do anything about that.

@addaleax Flaky due to rounding errors, or something else?

addaleax · 2019-11-12T19:04:18Z

@Trott It’s flaky because the stat calls for the regular version and the bigint version are made at different times, and so they leave a window for stat data changing in between, or at least that’s my understanding of where this comes from

duncanhealy · 2019-11-12T19:18:10Z

As for increasing the timeout, I’m okay because the test is just inherently flaky the way it’s written and we can’t really do anything about that.

@addaleax Flaky due to rounding errors, or something else?

lstat running twice first with {bigint:true} passed as parameter, on this test I was constistently getting 4ms difference for atime

@Trott It’s flaky because the stat calls for the regular version and the bigint version are made at different times, and so they leave a window for stat data changing in between, or at least that’s my understanding of where this comes from

Could we change the nested call instead? L135-139 test-fs-stat-bigint.js

 fs.lstat(link, { bigint: true }, (err, bigintStats) => {
    fs.lstat(link, (err, numStats) => {
      verifyStats(bigintStats, numStats);
    });

Trott · 2019-11-12T21:01:47Z

@Trott It’s flaky because the stat calls for the regular version and the bigint version are made at different times, and so they leave a window for stat data changing in between, or at least that’s my understanding of where this comes from

Sounds good to me. Thanks! Maybe a comment explaining that would be useful.

/ping @nodejs/testing

nodejs-github-bot · 2019-11-30T01:08:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27196/

addaleax · 2019-11-30T16:40:36Z

@duncanhealy Could you rebase this against the master branch, or squash the commits here together? Our CI doesn’t deal well with merge conflicts.

Trott · 2019-11-30T17:53:19Z

Subsystem should be test rather than doc. If this gets fixed in a rebase or whatever, then great. But if not, then it can be fixed when landing.

duncanhealy · 2019-11-30T19:28:19Z

@duncanhealy Could you rebase this against the master branch, or squash the commits here together? Our CI doesn’t deal well with merge conflicts.

changes squashed

test/parallel/test-fs-stat-bigint.js

Trott · 2020-02-07T22:45:53Z

The test does not seem to be failing anymore, so I'm going to close this. Feel free to re-open if you think that's the wrong thing to do and this should land regardless. I'm not acting on a strong opinion. I'm just doing a little tidying up. Thanks!

Trott · 2020-02-08T02:59:37Z

Stress test on FreeBSD shows this is still A Thing. Re-opening.

lundibundi · 2020-02-09T10:49:28Z

@Trott this actually fails for me locally on Arch Linux every now and then (the 2ms), so I'd be in favor of merging this unless we find a better solution.

Trott · 2020-02-09T11:09:35Z

I think if we update the comment and move the 5 magic number to a variable that has the comment right above it, this is good to land (with a clean CI).

Trott

LGTM with nits

Trott · 2020-02-09T11:23:43Z

I addressed the nits, updated the commit message, and pushed the changes to the PR branch.

Trott · 2020-02-09T11:25:42Z

@lundibundi Do the changes I made just now look good to you? If so, feel free to add the author ready label (or land it if CI is finished and green/yellow).

Change test limit for atime from 2ms to 5ms. Add comment explaining why the wiggle room is needed. Fixes: nodejs#24593

nodejs-github-bot · 2020-02-09T11:48:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29041/

Trott · 2020-02-11T05:02:15Z

So, this doesn't fully fix the test, but it fixes the issue with times being off. There's still an issue with the block count being wrong, somehow, but I'll open a separate issue for that after this lands.

Trott · 2020-02-11T05:04:55Z

Landed in 5b0308c...fb437c4

Change test limit for atime from 2ms to 5ms. Add comment explaining why the wiggle room is needed. Fixes: nodejs#24593 PR-URL: nodejs#30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: nodejs#30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Change test limit for atime from 2ms to 5ms. Add comment explaining why the wiggle room is needed. Fixes: #24593 PR-URL: #30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Change test limit for atime from 2ms to 5ms. Add comment explaining why the wiggle room is needed. Fixes: #24593 PR-URL: #30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Change test limit for atime from 2ms to 5ms. Add comment explaining why the wiggle room is needed. Fixes: #24593 PR-URL: #30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Change test limit for atime from 2ms to 5ms. Add comment explaining why the wiggle room is needed. Fixes: #24593 PR-URL: #30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 12, 2019

jasnell reviewed Nov 12, 2019

View reviewed changes

test/parallel/test-fs-stat-bigint.js Outdated Show resolved Hide resolved

Trott reviewed Nov 12, 2019

View reviewed changes

test/parallel/test-vm-function-declaration.js Outdated Show resolved Hide resolved

addaleax approved these changes Nov 30, 2019

View reviewed changes

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2019

addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 30, 2019

duncanhealy changed the title ~~doc: change test limit for atime from 2ms to 5ms~~ test: change test limit for atime from 2ms to 5ms Nov 30, 2019

duncanhealy force-pushed the test-fs-stat-bigint branch from 891ced4 to 499e4f2 Compare November 30, 2019 19:25

lundibundi approved these changes Dec 1, 2019

View reviewed changes

test/parallel/test-fs-stat-bigint.js Outdated Show resolved Hide resolved

Trott closed this Feb 7, 2020

Trott reopened this Feb 8, 2020

This comment has been minimized.

Sign in to view

Trott approved these changes Feb 9, 2020

View reviewed changes

Trott force-pushed the test-fs-stat-bigint branch 2 times, most recently from c1f6a81 to ac23f40 Compare February 9, 2020 11:23

This comment has been minimized.

Sign in to view

lundibundi approved these changes Feb 9, 2020

View reviewed changes

lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 9, 2020

duncanhealy and others added 2 commits February 9, 2020 01:32

test: fix flaky test-fs-stat-bigint

74d8578

Change test limit for atime from 2ms to 5ms. Add comment explaining why the wiggle room is needed. Fixes: nodejs#24593

test: remove flaky designation for test-fs-stat-bigint

daad06e

Trott force-pushed the test-fs-stat-bigint branch from ac23f40 to daad06e Compare February 9, 2020 11:33

Trott closed this Feb 11, 2020

codebytere pushed a commit that referenced this pull request Feb 17, 2020

test: remove flaky designation for test-fs-stat-bigint

fa9b592

PR-URL: #30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

codebytere mentioned this pull request Feb 17, 2020

v13.9.0 proposal #31837

Merged

codebytere pushed a commit that referenced this pull request Mar 15, 2020

test: remove flaky designation for test-fs-stat-bigint

c2be2ba

PR-URL: #30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

codebytere pushed a commit that referenced this pull request Mar 17, 2020

test: remove flaky designation for test-fs-stat-bigint

84c83d1

PR-URL: #30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

codebytere mentioned this pull request Mar 17, 2020

v12.16.2 proposal #32313

Merged

codebytere pushed a commit that referenced this pull request Mar 30, 2020

test: remove flaky designation for test-fs-stat-bigint

3f6805f

PR-URL: #30437 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: change test limit for atime from 2ms to 5ms #30437

test: change test limit for atime from 2ms to 5ms #30437

duncanhealy commented Nov 12, 2019

Trott commented Nov 12, 2019

addaleax commented Nov 12, 2019

Trott commented Nov 12, 2019

addaleax commented Nov 12, 2019

duncanhealy commented Nov 12, 2019

Trott commented Nov 12, 2019

nodejs-github-bot commented Nov 30, 2019

addaleax commented Nov 30, 2019

Trott commented Nov 30, 2019

duncanhealy commented Nov 30, 2019

Trott commented Feb 7, 2020

Trott commented Feb 8, 2020 •

edited

Loading

lundibundi commented Feb 9, 2020

This comment has been minimized.

Trott commented Feb 9, 2020

Trott left a comment

Trott commented Feb 9, 2020

This comment has been minimized.

Trott commented Feb 9, 2020

nodejs-github-bot commented Feb 9, 2020

Trott commented Feb 11, 2020

Trott commented Feb 11, 2020

test: change test limit for atime from 2ms to 5ms #30437

test: change test limit for atime from 2ms to 5ms #30437

Conversation

duncanhealy commented Nov 12, 2019

Checklist

Trott commented Nov 12, 2019

addaleax commented Nov 12, 2019

Trott commented Nov 12, 2019

addaleax commented Nov 12, 2019

duncanhealy commented Nov 12, 2019

Trott commented Nov 12, 2019

nodejs-github-bot commented Nov 30, 2019

addaleax commented Nov 30, 2019

Trott commented Nov 30, 2019

duncanhealy commented Nov 30, 2019

Trott commented Feb 7, 2020

Trott commented Feb 8, 2020 • edited Loading

lundibundi commented Feb 9, 2020

This comment has been minimized.

Trott commented Feb 9, 2020

Trott left a comment

Choose a reason for hiding this comment

Trott commented Feb 9, 2020

This comment has been minimized.

Trott commented Feb 9, 2020

nodejs-github-bot commented Feb 9, 2020

Trott commented Feb 11, 2020

Trott commented Feb 11, 2020

Trott commented Feb 8, 2020 •

edited

Loading